Bug 86248 - [Commands] request: ctrl+pageup/down action doesn't have item in preferences/keys
Summary: [Commands] request: ctrl+pageup/down action doesn't have item in preferences/...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0.1   Edit
Hardware: All All
: P5 enhancement with 1 vote (vote)
Target Milestone: 3.6 M2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 199499
Blocks:
  Show dependency tree
 
Reported: 2005-02-23 06:56 EST by Jan Ptacek CLA
Modified: 2009-09-15 14:37 EDT (History)
4 users (show)

See Also:


Attachments
Fix (5.22 KB, patch)
2009-04-27 05:54 EDT, Markus Keller CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Ptacek CLA 2005-02-23 06:56:44 EST
hi,
in 3.0.1 the behaviour of ctrl+pageup/down is much better and quickier inc
comparison to ctrl/shift/+f6

i want the same behaviour as ctrl+pageup triggers to be mapped on F1/F2
as some extension to firefox does it, but it is not possible to remap it, cos
there is no such item in preferences/keys anywhere
(i did go through all of them watchig for ctrl+pageup -> no success :( )
Comment 1 Michael Van Meekeren CLA 2006-04-21 13:21:51 EDT
Moving Dougs bugs
Comment 2 Marcelo Alvim CLA 2006-09-09 18:06:14 EDT
So, any news on this? Will we be able to rebind ctrl+pageup/ctrl+pagedown anytime soon? I only ask because I, too, have been wanting this for some time, now.

Real thanks!
Comment 3 Paul Webster CLA 2006-09-09 20:24:23 EDT
What behaviour does CTRL+PageUp trigger?  Can you not map CTRL+PageUp to the same command as CTRL+F6 in eclipse 3.2.0?

PW
Comment 4 Marcelo Alvim CLA 2006-09-11 02:34:26 EDT
No, they behave differently.

Ctrl+F6 opens up the little "Editors" window, a list of all the currently open files. If you hold down Ctrl and keep tapping F6, the selected element on the list is cycled between all the files. The list is ordered using a "last opened first" policy, it seems.

Ctrl+PageUp simply switches from the current file being edited to the previous open file, and Ctrl+PageDown switches to the next. "Next" and "Previous", in this context, meaning the order in which you see the files in the editor.

I'm currently using Eclipse 3.2.0 on Windows XP. 
Comment 5 Paul Webster CLA 2006-09-11 08:12:13 EDT
I'll check around, but I believe that functionality was replaced with the "last open first" behaviour in 3.1.

PW
Comment 6 Paul Webster CLA 2006-09-28 11:00:51 EDT
There are currently no plans to work on this feature.

PW
Comment 7 Denis Roy CLA 2007-06-22 09:32:48 EDT
Changes requested on bug 193523
Comment 8 A O CLA 2007-08-02 11:21:44 EDT
Ok, so what needs to happen so this feature does get into the plans?  

Eclipse has options to rebind nearly every single key/action I can think of, but the one (and only) action I want to rebind (to ctrl-tab and ctrl-shift-tab...like firefox and every other tabbed application I know of on Windows) isn't available!

Andy O
Comment 9 Paul Webster CLA 2007-08-02 11:38:09 EDT
(In reply to comment #8)
> Ok, so what needs to happen so this feature does get into the plans?  

Provide a working patch (that's the P5-helpwanted).

In order for there to be a keybinding there needs to be a command and a handler to do the work.

However, it looks like that behaviour is coded into SWT as traverse events: TRAVERSE_PAGE_PREVIOUS and TRAVERSE_PAGE_NEXT, which is what org.eclipse.swt.custom.CTabFolder is listener for.

AFAIK the keybinding to command would override the traverse event ... but then you would have to figure out how to get from the handler (which knows the active part) through the presentation API/TabbedStackPresentation to the actual CTabFolder (which API would need to be augmented).

PW
Comment 10 Daniel Terhorst CLA 2007-11-19 22:26:22 EST
In my opinion, this bug is deserving of a higher priority. The lack of a decent tabbing strategy is an unnecessary frustration to a smooth, keyboard-oriented workflow. 

The CTRL+F6/CTRL+Shift+F6 behavior is an awkward substitutes for CTRL+PageUp/CTRL+PageDown-like cycling; however, CTRL+PageUp/CTRL+PageDown cannot be remapped to convenient keys, like the prevalent CTRL+Tab/CTRL+Shift+Tab. 

(Referred from Bug #210311)
Comment 11 Paul Webster CLA 2007-11-20 06:24:41 EST
(In reply to comment #10)
> In my opinion, this bug is deserving of a higher priority. The lack of a decent
> tabbing strategy is an unnecessary frustration to a smooth, keyboard-oriented
> workflow. 

This is not on the plan.  However, I would consider patches if contributed.

i.e. providing a command and handler that worked for all of the stacks.  Once it's a command, it can be remapped to different keys.

PW
Comment 12 Markus Keller CLA 2007-11-22 09:58:01 EST
See also bug 43625 comment 9.
Comment 13 Markus Keller CLA 2009-04-27 05:54:26 EDT
Created attachment 133332 [details]
Fix

Adds two commands and a WidgetMethodHandler. I didn't assign default key bindings to the commands, since Ctrl+PageUp/Down is already handled natively on Win, GTK, and Cocoa.
Comment 14 Dani Megert CLA 2009-05-19 02:27:12 EDT
Paul can we put this on the 3.6 plate given a fix is attached?
Comment 15 Dani Megert CLA 2009-08-11 07:19:58 EDT
Paul, now would be a good time to commit the patch ;-)
Comment 16 Paul Webster CLA 2009-09-08 14:55:15 EDT
Released for >20090908

Thank you, Markus!

PW
Comment 17 Paul Webster CLA 2009-09-15 14:37:26 EDT
In I20090915-0100, using Next Tab and Previous Tab
PW