Bug 86243 - Undo/Redo implementation should propagate CoreExceptions
Summary: Undo/Redo implementation should propagate CoreExceptions
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 84446
Blocks:
  Show dependency tree
 
Reported: 2005-02-23 06:23 EST by Dirk Baeumer CLA
Modified: 2005-03-30 15:00 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2005-02-23 06:23:51 EST 
Must of the method that manipulate the workspace are throwing core exceptions.
Since the operations API doesn't allow throw core exceptions all the exception
have to be converted into a status which constains the risk of loosing stack
trace information. Refactoring itseld then as to take the status again and throw
a CoreException since it propagetes exceptions not status objects.

IMO the following methods should support throwing CoreException

IUndoableOperation#execute
IUndoableOperation#redo
IUndoableOperation#undo

IOperationHistory#execute
IOperationHistory#redo
IOperationHistory#redoOperation
IOperationHistory#undo
IOperationHistory#undoOperation
Comment 1 Susan McCourt CLA 2005-02-26 10:59:56 EST 
Per discussion in bug #84446, we are propagating ExecutionException instead of 
CoreException.  Implemented for I20050301 and beyond.  Released to HEAD on 
2/25/2005.
Comment 2 Susan McCourt CLA 2005-03-27 13:56:50 EST 
Fixed per bug #84446
Comment 3 Susan McCourt CLA 2005-03-30 15:00:48 EST 
verified on I20050330-0500