Bug 86221 - [Progess] [EditorMgmt] IWorkbenchSiteProgressService not fully implemented for editors
Summary: [Progess] [EditorMgmt] IWorkbenchSiteProgressService not fully implemented fo...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Remy Suen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-22 19:39 EST by Nick Edgar CLA
Modified: 2019-09-06 16:17 EDT (History)
8 users (show)

See Also:

Attachments
Suggested fix to bold the editor just like views. (11.48 KB, patch)
2008-11-12 03:39 EST, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-02-22 19:39:01 EST 
build 3.1 M5

- IWorkbenchSiteProgressService.warnOfContentChange() is implemented as:
site.getPane().showHighlight();

but showHighlight() is only implemented on ViewPane.

It should also work for editors.
Comment 1 Tod Creasey CLA 2007-06-14 13:06:41 EDT 
There are currently no plans to work on this although we would be happy to review a patch
Comment 2 Remy Suen CLA 2008-11-12 03:39:02 EST 
Created attachment 117637 [details]
Suggested fix to bold the editor just like views.

This patch will implement showHighlight() in the same manner that views do wherein a property change will be fired and the editor's tab will have its text bolded. A test for editors and views are included in this patch.

I'll leave this open for a while in case somebody else feels that the behaviour should be different for editors. If no one says anything, I will take your silence as a "sounds good to me" and release the patch to HEAD.
Comment 3 Remy Suen CLA 2008-11-12 03:41:14 EST 
Adding Tod back to this bug on CC. Tod, I'm planning to bold the editors so that the behaviour is the same for views, if you feel otherwise, let me know.
Comment 4 Tod Creasey CLA 2008-11-12 08:39:56 EST 
This is a fairly big behaviour change. I agree with the idea but Kevin should be made aware of it.
Comment 5 Remy Suen CLA 2008-12-01 07:34:24 EST 
Kevin, do you have any comments about this behavioural change?
Comment 6 Min Idzelis CLA 2009-06-23 15:03:26 EDT 
Any updates on this one?
Comment 7 Remy Suen CLA 2009-06-23 15:05:00 EDT 
(In reply to comment #4)
> This is a fairly big behaviour change. I agree with the idea but Kevin should
> be made aware of it.

Kevin? Would bolding the editor's text be okay?
Comment 8 Remy Suen CLA 2009-09-15 19:29:17 EDT 
“Kevin, do you agree?”
“Kevin, can I take this bug?”
“Kevin, are you there?”
“Wake up Kevin!”

http://dev.eclipse.org/blogs/kevinmcguire/2008/12/04/experiments-with-bugzilla-email-filtering/
Comment 9 Eclipse Webmaster CLA 2019-09-06 16:17:50 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.