Bug 85370 - [string variables] string_prompt for passwords
Summary: [string variables] string_prompt for passwords
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-02-16 03:30 EST by Christian Halstrick CLA
Modified: 2007-10-26 12:03 EDT (History)
1 user (show)

See Also:

Attachments
new dynamic variable (14.15 KB, patch)
2007-10-25 15:31 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Halstrick CLA 2005-02-16 03:30:35 EST 
When creating runtime-configurations I can use the string_prompt variable to ask
the user for string values whenever the configuration is started. I suggest to add
something which allows me to ask for passwords. It should work like string_prompt
but while typing the characters are displayed as '*'.
Comment 1 Darin Wright CLA 2005-02-16 08:32:24 EST 
Deferred. A contribution would be welcome.
Comment 2 Curtis Windatt CLA 2007-09-21 17:16:19 EDT 
This seems a little odd, as string variables are not in any way secure.  Starring out the prompt might just give the user a false sense of security.  That being said, this would be simple to implement, so I am adding the helpwanted and bugday keywords.
Comment 3 Benjamin Muskalla CLA 2007-10-25 15:25:41 EDT 
Reopening as LATER is deprecated.
Comment 4 Benjamin Muskalla CLA 2007-10-25 15:31:41 EDT 
Created attachment 81192 [details]
new dynamic variable

Fix for this feature request is attached. At the moment the password input dialog is just a copy of the JFace input dialog with an additional style flag for the text widget. We should think about extending input dialog directly.Therefor we would need to override the style tags of the text field which should be offered by Jface (like Window#setShellStyle).
Comment 5 Curtis Windatt CLA 2007-10-25 15:37:10 EDT 
Just because LATER is deprecated does not mean we are reopening all bugs marked as such.  Just pointing it out so you don't start reopening bugs you aren't planning to fix :)

Thanks for the patch.  I'll look at it tomorrow as part of bug day.
Comment 6 Curtis Windatt CLA 2007-10-26 12:03:04 EDT 
Made significant changes to the patch so that it only requires one class and so we don't duplicate the entire InputDialog class.

Fixed in HEAD.  See PasswordPrompt.java
Comment 7 Curtis Windatt CLA 2007-10-26 12:03:50 EDT 
Verified.

Thanks for the patch Benjamin