Bug 84636 - [MPE] MultiPageEditorPart does not remove property listener on nested editor
Summary: [MPE] MultiPageEditorPart does not remove property listener on nested editor
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2005-02-07 17:32 EST by Nick Edgar CLA
Modified: 2019-09-06 15:30 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-02-07 17:32:58 EST
build I20050202

In MultiPageEditorPart.addPage(IEditorPart, IEditorInput), it adds a property
listener:

        editor.addPropertyListener(new IPropertyListener() {
            public void propertyChanged(Object source, int propertyId) {
                MultiPageEditorPart.this.handlePropertyChange(propertyId);
            }
        });

This listener is never removed.  This shouldn't actually be a problem, as
typically the nested editor is disposed whenever the outer editor is disposed,
or when the nested editor is removed, and WorkbenchPart.dispose() clears the
property listener list.

But it would be better to manage the property listener in MultiPageEditorSite,
and remove it in the site's dispose() method.
Comment 1 Eclipse Webmaster CLA 2019-09-06 15:30:15 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.