Bug 8336 - Search view should have toolbar actions in context menu
Summary: Search view should have toolbar actions in context menu
Status: RESOLVED DUPLICATE of bug 10265
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2002-01-23 16:52 EST by Nick Edgar CLA
Modified: 2002-08-30 05:49 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2002-01-23 16:52:42 EST
Build 20020123

I wanted to do a search, and figured I could find the action on the search 
view in addition to the toolbar button.
It's there on the search toolbar, but not on its context menu.
This is awkward for accessibility.  Toolbar buttons are hard to get to with 
keyboard only.
Now, search also appears in the Edit menu, and even has an accelerator 
(Ctrl+H), but this is not the most visible.

In general, toolbar buttons should be shortcuts for what's available on the 
menus.  In the case of the view toolbar, toolbar actions should also appear on 
its context menu.
Comment 1 Erich Gamma CLA 2002-01-24 05:45:41 EST
I don't mind to change this, but we have flipped this already more than once. 
For 1.0 the rule was to not replicate View actions that are not selection 
sensitive in the context menu. I agree with your accessability concern. 

There is need for some guidelines:
- which actions go into a View's context menu
- which actions go into the View's drop down menu
- which actions go into the View's toolbar.
Comment 2 Tod Creasey CLA 2002-03-14 13:21:43 EST
Usability rather than accessibility issue as the tool bar can be navigated to
Comment 3 Erich Gamma CLA 2002-05-04 20:01:18 EDT
The global Search menu will make search more visible.

Most actions are now also available on the context menu.

The only exception is the search history. We should consider adding the search 
history dialog as an action to the global Search menu. This will improve 
accessability and it is also a function that belongs there.

Comment 4 Erich Gamma CLA 2002-05-12 09:01:09 EDT
pls check the user interface guidelines with regard to the View menu
Comment 5 Dani Megert CLA 2002-05-22 03:43:36 EDT
Could not find this in UI guidelines: it says they have to be in the menu which
I understand as being in the (main) menu and not the context menu.

This would mean to add the following actions to the global Search menu:
- Next Match (should be merged with Next error - retarget)
- Previous Match (should be merged with Next error - retarget)
- Remove Match
- Remove All Searches
- History
Comment 6 Nick Edgar CLA 2002-05-24 00:53:00 EDT
Actions on toolbars also have to be available via the menus.
Toolbar items should be thought of as shortcuts for what's on the menus.
Generally we put actions which apply to the selection in the context menu.
Actions which apply to the view as a whole (e.g. filtering / sorting) should 
go on the view menu (the triangle).
Comment 7 Dani Megert CLA 2002-06-18 02:48:27 EDT
History operations are still not in a menu.
Should offer a Search History view.
Consider after 2.0. 

Comment 8 Dani Megert CLA 2002-08-30 05:48:21 EDT
reopen to mark as duplicate
Comment 9 Dani Megert CLA 2002-08-30 05:49:29 EDT
The last remaining issue (Search History view) is covered by the another PR.

*** This bug has been marked as a duplicate of 10265 ***