Bug 82541 - [Dialogs] SaveAsDialog should better handle closed projects
Summary: [Dialogs] SaveAsDialog should better handle closed projects
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P4 minor (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-01-11 06:30 EST by Dani Megert CLA
Modified: 2007-03-20 11:14 EDT (History)
1 user (show)

See Also:

Attachments
patch_save_as_dialog_closed_projects.diff (1.44 KB, patch)
2006-07-23 03:24 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2005-01-11 06:30:21 EST 
I20050111-0800

The SaveAsDialog show closed projects and even enables the OK button. This makes
no sense since we cannot save the file into a closed projects. An error dialog
is the result.

I suggest to disable the OK button if a closed project is selected.
Comment 1 Benjamin Muskalla CLA 2006-07-23 03:24:31 EDT 
Created attachment 46682 [details]
patch_save_as_dialog_closed_projects.diff

Here is a little patch to disable the "Ok" button if a closed project is selected.

I think in this case, we should consider to improve the whole thing like the patch in #48197 does it. An option to show/hide closed projects and a double-click listener to open closed projects.

What do you think Susan?
Comment 2 Susan McCourt CLA 2006-07-24 15:54:04 EDT 
I'll take a look at this patch for 3.3 (not sure of which milestone yet)...
Thanks.
Comment 3 Benjamin Muskalla CLA 2007-01-09 17:39:59 EST 
Any work on this done Susan?
Comment 4 Susan McCourt CLA 2007-01-11 13:59:42 EST 
none yet...I'm on maternity leave right now but will be back before 3.3 ships
Comment 5 Susan McCourt CLA 2007-02-13 19:16:30 EST 
assigning to M6.  I tend to favor the simple approach (simply disable OK on close projects) but I'll have a look at the patch.
Comment 6 Susan McCourt CLA 2007-03-15 18:19:13 EDT 
Fixed >20070315.
Thanks for the patch, Benjamin.
I altered it a bit, mainly to ensure that a descriptive error message is set when a closed project is detected.
Comment 7 Benjamin Muskalla CLA 2007-03-15 18:26:45 EDT 
Thanks Susan!
Comment 8 Susan McCourt CLA 2007-03-20 11:14:57 EDT 
verified WinXP, I20070320-0010