Bug 82476 - [Preferences] [RCP] Verify that the preference key to close editors on shutdown is API
Summary: [Preferences] [RCP] Verify that the preference key to close editors on shutdo...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2005-01-10 10:22 EST by Pascal Rapicault CLA
Modified: 2005-05-10 17:14 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2005-01-10 10:22:11 EST
Comment 1 Nick Edgar CLA 2005-01-10 15:54:21 EST 
No, it's internal.  See IPreferenceConstants.CLOSE_EDITORS_ON_EXIT.
Comment 2 Nick Edgar CLA 2005-03-22 17:29:22 EST 
Fixed.  This pref does not appear in the IDE anymore, but I've made the constant
API to allow RCP apps to configure this behaviour.
Comment 3 Nick Edgar CLA 2005-03-31 14:49:35 EST 
Not properly fixed.  The pref was still being read from the internal store.
Comment 4 Nick Edgar CLA 2005-03-31 14:50:56 EST 
Patch is to use this in Workbench.busyClose:

		boolean closeEditors = PrefUtil.getAPIPreferenceStore().getBoolean(
                IWorkbenchPreferenceConstants.CLOSE_EDITORS_ON_EXIT);
Comment 5 Nick Edgar CLA 2005-03-31 14:52:02 EST 
Workaround for RCP apps in M6 is to specify:
org.eclipse.ui.workbench/CLOSE_EDITORS_ON_EXIT=true
instead of
org.eclipse.ui/CLOSE_EDITORS_ON_EXIT=true
in the plugin_customization.ini file.
Comment 6 Nick Edgar CLA 2005-04-19 17:15:43 EDT 
Fixed.
Comment 7 Nick Edgar CLA 2005-05-10 17:13:48 EDT 
org.eclipse.ui/CLOSE_EDITORS_ON_EXIT=true
Comment 8 Nick Edgar CLA 2005-05-10 17:14:05 EDT 
Woops. I meant: Verified in I20050509-2010.