Bug 80577 - [Repo View] Author not shown in remote compares
Summary: [Repo View] Author not shown in remote compares
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P4 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
: 131669 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-12-09 04:49 EST by Dani Megert CLA
Modified: 2009-06-02 07:17 EDT (History)
2 users (show)

See Also:

Attachments
Picture showing compare editor and preferences (20.80 KB, image/png)
2004-12-09 04:50 EST, Dani Megert CLA 		no flags Details
Patch_v01 (13.56 KB, patch)
2008-12-01 10:10 EST, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2004-12-09 04:49:45 EST 
I20041208-1200

I've enabled "Show the file author in compare editors" but as you can see in the
attached picture the preference is not working.
Comment 1 Dani Megert CLA 2004-12-09 04:50:23 EST 
Created attachment 16486 [details]
Picture showing compare editor and preferences
Comment 2 Michael Valenta CLA 2004-12-09 09:06:38 EST 
It works for comparisons involving local resources but not for comparisons 
between two remotes.
Comment 3 Dani Megert CLA 2006-07-05 08:42:20 EDT 
Any change we get this for 3.3? It would save quite some time when comparing versions: currently I have to go ton the History view to get the information.
Comment 4 Michael Valenta CLA 2006-12-07 08:38:55 EST 
*** Bug 131669 has been marked as a duplicate of this bug. ***
Comment 5 Michael Valenta CLA 2006-12-07 09:06:40 EST 
I've added the author to Compares open from the History view but there are still a few places where the author will not appear:

1) Comparisons opened from the Repo view

2) Single file comparisons performed from the Navigator. This is only an issue with the non-model based sync since the model based sync does not open files automatically.

Fixing these places would be a fair amount of work so I am deferring it to post 3.3.
Comment 6 Dani Megert CLA 2007-06-14 10:03:33 EDT 
Any chance for 3.4? ;-)
Comment 7 Michael Valenta CLA 2007-06-14 10:31:05 EDT 
We'll target for 3.4 but I can't guarantee we'll get to it since we don;t know what the plan for 3.4 is yet.
Comment 8 Szymon Brandys CLA 2008-04-15 11:45:24 EDT 
This one can wait for a volunteer.
Comment 9 Dani Megert CLA 2008-11-27 03:08:45 EST 
Maybe when looking at this you can also look at bug 241211.
Comment 10 Dani Megert CLA 2008-11-27 03:09:12 EST 
And this one too: bug 138853  :-)
Comment 11 Pawel Pogorzelski CLA 2008-12-01 10:10:42 EST 
Created attachment 119149 [details]
Patch_v01
Comment 12 Tomasz Zarna CLA 2008-12-02 05:28:59 EST 
Released to HEAD, in the meantime Pawel suggested to add null check when getting the adapter. It's there.

[1] org.eclipse.team.internal.ui.Utils.getAuthor(IResourceVariant, IProgressMonitor)
Comment 13 Dani Megert CLA 2008-12-03 07:18:13 EST 
Verified in I20081202-1812.