Bug 79828 - [DynamicGUI] Disabling feature leaves workbench state with errors
Summary: [DynamicGUI] Disabling feature leaves workbench state with errors
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-30 17:02 EST by Donald Warren CLA
Modified: 2019-09-06 15:33 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Donald Warren CLA 2004-11-30 17:02:03 EST
Our QE team has found these problems with our feature due to Eclipse behavior 
in disabling features.  These problems can be reproduced with another feature 
that contributes its own perspective (such as CDT).

1.  A perspective contributed by our feature is open.  The user disables the 
feature and restarts Eclipse.  Eclipse reports "Could not restore workbench 
layout.  Reason: Problems occurred restoring workbench" because it is trying 
to restore the state of the perspective which is no longer available.  (QE 
expected a valid perspective to be opened instead.)

2.  Additionally, the tab for the perspective which is no longer available is 
still drawn.

3.  Now re-enable the feature.  The custom views in the perspective are not 
reopened.  (QE expected the perspective to be reset to its default state.)
Comment 1 Dorian Birsan CLA 2004-11-30 18:54:32 EST
Moving to UI for comments...

When the update manager disables a feature, the user is prompted to restart. 
At this time, the bundles contributed for this feature are only "tagged" for 
uninstall, but the actual bundle uninstall happens upon restart: when 
restarting, the update configurator calls the osgi API's to uninstall the 
bundles just disabled. I am not sure if the runtime actually notifies 
listeners (assuming eclipse ui is listening for uninstall events), but this 
would be where the ui could, perhaps, react to bundle uninstall.
Comment 2 Kim Horne CLA 2004-11-30 21:10:19 EST
I would hope that the bundle uninstall would happen before the workbench was
started.  If it happens after the workbench is started then we currently do not
handle this case.  I suspect the problem is simpler... we're probably not
handling a missing perspective well in our restoreState code.  We should just
fall back to the default in this case.
Comment 3 Eclipse Webmaster CLA 2019-09-06 15:33:01 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.