Bug 7969 - Editor re-use in Debugger
Summary: Editor re-use in Debugger
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 1577
Blocks:
  Show dependency tree
 
Reported: 2002-01-21 15:46 EST by Darin Wright CLA
Modified: 2002-05-02 10:10 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2002-01-21 15:46:43 EST
Erich Gamma: "since the editor reuse policy can only be set globally and not 
per perspective you end up with many open editors in the debug perspective. It 
can happend that ones your are working one get closed because of the ones 
opened by the debugger."

Would be nice to be able to control editor re-use by perspective.
Comment 1 Erich Gamma CLA 2002-01-21 18:19:48 EST
oops, my words are really hard to understand...

2nd attempt:
Since you can only set the editor reuse preference globally and not per 
perspective you can end up with many open editors in the debug perspective. For 
example, I've set it to 8. When stepping through code you quickly get to the 
reuse threshold and as a consequence editors that I was working with can get 
reused and I have to reopen them. I find myself to often fall back to the 
old "close all editors" pattern.

Pinning can help to avoid that the editors I'm working with are getting closed. 
However, I often forget to pin an editor. 

Random ideas
- editors that I've changed once during my session should be pinned 
automatically or should considered specially in the reuse policy.
- support to close all editors except the pinned ones.
- I can set editor reuse policy per perspective, i.e., for the debug 
perspective I would set it 1 (giving me the old behaviour).

Comment 2 Erich Gamma CLA 2002-01-24 07:08:31 EST
one option to consider is whether we should fall back to the manual editor 
reuse policy when opening editors from the debug view. However, I'd like to get 
more user feedback on this one.
Comment 3 Darin Wright CLA 2002-02-04 16:25:05 EST
We can now set the editor threshold in the debug perspective to be different 
that the workbench preference.
Comment 4 Darin Swanson CLA 2002-02-05 12:18:40 EST
Set editor threshold to 1 in the DebugPerspectiveFactory.

Works in most cases...
Failure:
Select a stack frame
Hit F3 to open a new type from seleted source (System.out.println())

The PrintStream.class is opened AND the editor for the debug source is also 
open.
Comment 5 Darin Swanson CLA 2002-02-11 17:31:18 EST
Problem is that the launch view is activated when the "old" editor is closed 
and the new editor is not yet opened.

Is this intentional...seems strange to activate another part when the 
EditorManager is about to replace the old editor with the new one.  Would seem 
to lead to flash.
Comment 6 Darin Wright CLA 2002-02-26 12:58:56 EST
Moving to platform UI.
Comment 7 Kevin Haaland CLA 2002-05-01 14:24:53 EDT
Nick, please confirm that the editor reuse isses raised by the debugger team 
have been resolved for 2.0
Comment 8 Nick Edgar CLA 2002-05-02 08:59:12 EDT
Darin, can this be closed?
Comment 9 Darin Wright CLA 2002-05-02 09:06:25 EDT
Yes, this can be closed. The debugger manages its own editor re-use in the 
current code base.
Comment 10 Nick Edgar CLA 2002-05-02 10:10:08 EDT
Closing.