Bug 78007 - [Commands] [Dialogs] Leak from WorkbenchContextSupport
Summary: [Commands] [Dialogs] Leak from WorkbenchContextSupport
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2004-11-05 19:20 EST by Darin Swanson CLA
Modified: 2005-03-21 16:21 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2004-11-05 19:20:16 EST 
Hovering in a JavaEditor provides a popup that can be converted to a "sticky" 
scrollable (default by pressing F2).

If this sticky popup is dismissed using ESC, the WorkbenchContextSupport 
dispose listener that is added to the new shell on line 325 "fires" and 
removes itself and the EnabledSubmission(s).

If the stick popup is dismissed just be clicking back in the editor the 
dispose listener does not get the widgetDisposed callback and the dispose 
listener and enabled submissions are not removed.
Comment 1 Douglas Pollock CLA 2004-11-08 16:51:48 EST 
This appears to be a bug with any shell that is cached, and not disposed.  For 
example, the key assist dialog.
Comment 2 Douglas Pollock CLA 2005-02-23 13:49:09 EST 
Stefan has made some changes here today....
Comment 3 Douglas Pollock CLA 2005-02-28 13:54:20 EST 
I believe this was fixed by Stefan's change on Bug 84279, but I'm not sure.  I
cannot reproduce the leak using N20050228-0010.

Please re-open if this is still a problem for you.
Comment 4 Darin Swanson CLA 2005-03-21 16:21:58 EST 
Could no longer reproduce the problem on I20050315