Bug 77944 - [Change Sets] Comment dialog: Use comment as title
Summary: [Change Sets] Comment dialog: Use comment as title
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P5 enhancement (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 144200 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-05 09:26 EST by Markus Keller CLA
Modified: 2007-08-07 10:53 EDT (History)
4 users (show)

See Also:


Attachments
"Edit Change Set Comment" dialog (12.24 KB, image/png)
2007-04-25 08:21 EDT, Tomasz Zarna CLA
no flags Details
patch to org.eclipse.team.cvs.ui (9.11 KB, patch)
2007-07-07 23:12 EDT, Brock Janiczak CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2004-11-05 09:26:46 EST
I200411042000

The Change Set Comment dialog currently offers 2 options:
A) 'Use title as commit comment': can only enter a one-line name/comment
B) 'Enter a commit comment': can enter a one-line name and a free text comment

What I would need most of the time is just the other way 'round:
C) 'Use commit comment as title': can enter a free text multi-line comment and
first line is used as title.

I would like to see the dialog reorganized to something like this:

+---------------------------------------------+
| Commit comment:                             |
| +-----------------------------------------+ |
| | <Free text multi-line                   | |
| | comment                                 | |
| | ...>                                    | |
| +-----------------------------------------+ |
|                                             |
| Choose a previously entered comment:        |
| +-----------------------------------------+ |
| | [Combo with previous comments]        V | |
| +-----------------------------------------+ |
|                                             |
|                  +------------------------+ |
| Name (optional): | One-line name          | |
|                  + -----------------------+ |
+---------------------------------------------+

When no name is given, the commit comment should be used as name.
Comment 1 Michael Valenta CLA 2004-11-08 12:03:47 EST
I like this format as well.
Comment 2 Michael Valenta CLA 2005-03-30 10:57:14 EST
No time for this in 3.1
Comment 3 Michael Valenta CLA 2006-05-30 09:09:28 EDT
*** Bug 144200 has been marked as a duplicate of this bug. ***
Comment 4 Tomasz Zarna CLA 2007-04-25 07:18:58 EDT
This bug looks to be fixed in I20070424-0930.
Comment 5 Markus Keller CLA 2007-04-25 08:02:37 EDT
> This bug looks to be fixed in I20070424-0930.

Nope, the Change Set dialog has unfortunately not been changed so far.
You probably looked at the Commit dialog.
Comment 6 Michael Valenta CLA 2007-04-25 08:17:03 EDT
We can look at this in 3.4.
Comment 7 Tomasz Zarna CLA 2007-04-25 08:21:23 EDT
Created attachment 64858 [details]
"Edit Change Set Comment" dialog

Markus, could you take a look at the screenshot, so I'll make sure we are talking about the same dialog. This screenshot is taken from I20070424-0930.
Comment 8 Markus Keller CLA 2007-04-25 08:37:25 EDT
(In reply to comment #7)
Yes, that's the guy!
Comment 9 Michael Valenta CLA 2007-04-25 08:41:42 EDT
What Markus is suggesting is to switch the comment and title around so that, by default, the user only needs to enter a comment and the comment (or, at least the first line of it) will be used as the title of the change set. If the first line should be the title, then we provide the user with a means of providing an optional title.
Comment 10 Tomasz Zarna CLA 2007-04-25 08:43:00 EDT
Sorry, it's my fault. Now, when I've taken a closer look, I see your point. Next comment will be a comment to a patch ;)
Comment 11 Brock Janiczak CLA 2007-07-07 23:12:13 EDT
Created attachment 73262 [details]
patch to org.eclipse.team.cvs.ui

Patch to move the commit set title to the bottom of the screen and derive it from the current commit message
Comment 12 Michael Valenta CLA 2007-07-09 09:11:32 EDT
Thanks for the patch.
Comment 13 Michael Valenta CLA 2007-07-10 14:20:53 EDT
Patch released. Thanks again.
Comment 14 Tomasz Zarna CLA 2007-08-07 06:03:37 EDT
Verified in I20070806-1800. Thanks for the patch Brock.