Bug 77840 - [About] More Info button does nothing if Eclipse installed into location with spaces in path (on Linux)
Summary: [About] More Info button does nothing if Eclipse installed into location with...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0.1   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.0.2   Edit
Assignee: B. Chen CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2004-11-04 10:54 EST by Daniel M. Schumacher CLA
Modified: 2005-03-18 18:18 EST (History)
4 users (show)

See Also:

Attachments
fix attempt (12.55 KB, text/plain)
2005-01-14 16:40 EST, B. Chen CLA 		no flags Details
Patch to "org.eclipse.ui.workbench" (1.81 KB, patch)
2005-01-18 05:36 EST, Douglas Pollock CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel M. Schumacher CLA 2004-11-04 10:54:06 EST 
1. Install Eclipse into a directory containing spaces in the name 
(e.g. "/opt/eclipse301\ sdk").  
2. Start Eclipse.
3. Open Help > About > Feature Details and select a feature.
4. Click More Info -- nothing happens.

If installed into a directory that does not contain spaces, then this works 
fine.  And works fine on Windows in either case.  

It's understood that using paths with spaces is not that common in Linux, but 
it is possible and valid to do so.  So this should work in that case...
Comment 1 B. Chen CLA 2005-01-07 12:06:54 EST 
Any progress on fixing this problem?
Comment 2 Nick Edgar CLA 2005-01-10 15:29:39 EST 
Beth, would you be willing to investigate a patch for this?
See AboutFeaturesDialog.handleMoreInfoPressed(), which ends up calling
ProductInfoDialog.openLink.
Comment 3 B. Chen CLA 2005-01-10 15:53:18 EST 
We will look into this problem. May need your help.
Comment 4 Nick Edgar CLA 2005-01-14 16:32:06 EST 
Beth to supply patch for 3.0.2.
Comment 5 B. Chen CLA 2005-01-14 16:39:46 EST 
We have came up a fix for defect #77840. Please review the fix. If it's 
possible, we would like this fix to be in the 3.0.2 release.

The source code has comments with //77840 for the changes we made, we had 
added a new method urlEncodeForSpaces to take care of the space.
Comment 6 B. Chen CLA 2005-01-14 16:40:46 EST 
Created attachment 17176 [details]
fix attempt
Comment 7 Douglas Pollock CLA 2005-01-18 05:35:13 EST 
The attachment does not appear to be a patch.  It is a copy of the 
ProductInfoDialog containing the changes.  It is easier to work with submitted 
work if it comes in the form of a patch.  To create a patch, right-click on 
the file in the package explorer and select "Team > Create Patch...". 
 
This *might* have bizarre effects with particular combinations of VMs (i.e., 
how they implement exec) and shells (i.e., non-sh compliant). 
 
I've tested this by creating a plug-in project with spaces in the name.  With 
the patch, the info page appears without any problems.  Without the patch, 
badness ensues. 
 
Looks good to me.
Comment 8 Douglas Pollock CLA 2005-01-18 05:36:47 EST 
Created attachment 17234 [details]
Patch to "org.eclipse.ui.workbench"

Converts the given file into a patch, and removes changes to spacing.  Minor
formatting changes included.

This patch is intended for the 3.0.2 stream.
Comment 9 Nick Edgar CLA 2005-01-18 13:57:14 EST 
This conversion may also be needed on the Mac.  Michael, could you try the
original steps?
Comment 10 Nick Edgar CLA 2005-01-18 14:22:47 EST 
Patch applied to the head and 3.0.x streams.
Comment 11 Nick Edgar CLA 2005-03-10 14:04:53 EST 
Beth, could you please verify that this is fixed in the 3.0.2 RC2 build?
Comment 12 B. Chen CLA 2005-03-18 17:19:10 EST 
I have verified the fix, it's working.
Comment 13 Nick Edgar CLA 2005-03-18 18:18:18 EST 
Thanks Beth.