Bug 76967 - [RCP] IWorkbenchAction should be API
Summary: [RCP] IWorkbenchAction should be API
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M4   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2004-10-25 15:35 EDT by Jean-Michel Lemieux CLA
Modified: 2004-12-15 15:05 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Michel Lemieux CLA 2004-10-25 15:35:50 EDT 
Was it intentional to mark this class as not subclassable? Is it expected that
every client implement their own disposable action interface?
Comment 1 Nick Edgar CLA 2004-10-25 16:47:24 EDT 
IWorkbenchAction currently states:

     * <p>
     * This interface is not intended to be implemented by clients.
     * </p>

This is too restrictive.  In fact, some of the actions provided by the IDE
layer, in IDEActionFactory, already implement IWorkbenchAction.
Comment 2 Jean-Michel Lemieux CLA 2004-10-25 20:11:20 EDT 
Since ActionFactory can be subclassed it implies that clients must be able to
implement IWorkbenchAction.
Comment 3 Nick Edgar CLA 2004-12-08 21:24:40 EST 
Fixed.
Comment 4 Nick Edgar CLA 2004-12-15 15:05:51 EST 
Verified in I20041214-2000.