Bug 76726 - [Jobs][Progress] Redesign job error dialog
Summary: [Jobs][Progress] Redesign job error dialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P4 enhancement (vote)
Target Milestone: 3.1 M3   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 76582 81304 (view as bug list)
Depends on:
Blocks: 76582
  Show dependency tree
 
Reported: 2004-10-20 23:17 EDT by Chris Gross CLA
Modified: 2004-12-15 15:50 EST (History)
3 users (show)

See Also:


Attachments
Patch to JFace which adds API to ErrorDialog (8.66 KB, patch)
2004-10-26 16:06 EDT, Michael Valenta CLA
no flags Details | Diff
Patch to Workbench which improves concurreny error dialog usability (68.01 KB, patch)
2004-10-26 16:06 EDT, Michael Valenta CLA
no flags Details | Diff
Patch to Workbench TextEditor which changes QuickDiff error reporting to delay prompting (4.13 KB, patch)
2004-10-26 16:07 EDT, Michael Valenta CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gross CLA 2004-10-20 23:17:15 EDT
The job error dialog is very confusing. It shows two lists in a sort of 
master/detail paradigm.  When you first see the error, you have to click on the 
first error listing in the top of the dialog to see the actual error message in 
the bottom of the dialog.  This is not obvious.  Furthermore, there is no text 
on the dialog to give users any help.

Suggest that, if there is only one error reported, that you use the regular 
single error dialog (that dialog does appear if you click the 'job-errored' 
icon in the status line of the workbench).  If multiple errors occur then use a 
multi-error dialog.  And redesign a new multi-error dialog that is a little 
easier for the user to understand.  Perhaps a listing of the errors in a 
FormText where the error title and error text could be displayed without the 
user clicking on each error individually (just an idea).
Comment 1 Tod Creasey CLA 2004-10-21 08:17:09 EDT
Michael Valenta (one of the Team committers) is working on this now.
Comment 2 Jean-Michel Lemieux CLA 2004-10-21 08:36:36 EDT
Note that I've never seen more than one error reported in the dialog, hence in
the 99.9% case the regular error dialog is better. We are also adding support
for the 'goto' action for jobs so that a job returning an error could allow the
user to run some action to help them understand the error better. In the CVS
case, we are going to show the console.

Michael will provide a patch to Tod.
Comment 3 Michael Valenta CLA 2004-10-26 16:06:14 EDT
Created attachment 15406 [details]
Patch to JFace which adds API to ErrorDialog
Comment 4 Michael Valenta CLA 2004-10-26 16:06:57 EDT
Created attachment 15407 [details]
Patch to Workbench which improves concurreny error dialog usability
Comment 5 Michael Valenta CLA 2004-10-26 16:07:57 EDT
Created attachment 15408 [details]
Patch to Workbench TextEditor which changes QuickDiff error reporting to delay prompting
Comment 6 Michael Valenta CLA 2004-10-26 16:20:30 EDT
I've attached the patches that address the usability of error reporting for 
jobs. Here is a summary of the changes:

1) The dialog is optimized for the single error case in the sense that it will 
look like a normal error dialog. Multiple errors will be shown in a list that 
is ordered by the time of the error. Doing this properly involved adding API 
to ErrorDialog to support the showing of the details area programmatically and 
changing the status that is displayed by the details area. I have also 
modified the status details display of ErrorDialog to look for CoreExceptions 
inside of status so that as much as possible information is presented in the 
details.

2) When multiple errors occur, the dialog will auto-expand the details area 
and ensure that one of the jobs is selected so the details are shown. The list 
will automatically update with new job errors as they come in.

3) For jobs that define a GOTO action, the dialog will display a button that 
will allow the user to perform that action. This alows CVS operation errors to 
link to the CVS Console which displays more details about the operation that 
failed.

4) A progress property for delaying the error prompt has been added. When set, 
an error returned by a job will not result in a prompt until the user requests 
information about the error from the progress view or progress indicator or 
until another error occurs for which the property is not set.

I would appreciate it if this could be dealt with fairly promptly (i.e. for M3 
if possible). The current dialog is the cause of much confusion for users.
Comment 7 Tod Creasey CLA 2004-10-27 11:21:26 EDT
Patch released with some modifications after some consulation with Michael for 
build >20041027
Comment 8 Michael Valenta CLA 2004-10-27 11:27:14 EDT
*** Bug 76582 has been marked as a duplicate of this bug. ***
Comment 9 Tod Creasey CLA 2004-11-03 16:29:19 EST
Verified in 20041102
Comment 10 Tod Creasey CLA 2004-12-15 15:50:08 EST
*** Bug 81304 has been marked as a duplicate of this bug. ***