Bug 75934 - [ActionSets] [Contributions] Allow an action set's menus and toolbar to be customized independently
Summary: [ActionSets] [Contributions] Allow an action set's menus and toolbar to be cu...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 enhancement with 3 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 244583 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-08 13:54 EDT by Troy Bishop CLA
Modified: 2019-09-06 15:30 EDT (History)
6 users (show)

See Also:


Attachments
Path with proposed fix. (41.37 KB, patch)
2008-08-21 16:57 EDT, Pawel Piech CLA
no flags Details | Diff
Screenshot of the customize perspective dialog with suppress toolbar feature. (72.27 KB, image/png)
2008-08-21 16:58 EDT, Pawel Piech CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Troy Bishop CLA 2004-10-08 13:54:41 EDT
This is a request to separate the menubar and toolbar details in the customize
perspective dialog so that I can select to remove only the menubar or the
toolbar rather than both (as it works right now).  For example, if I unselect
the 'Java Navigation' command group then it removes both the menubar and
toolbar, but I may want to remove just the toolbar (for potentially getting back
some screen real estate) but I still want to menubar to be visible incase I need
to invoke one of those actions.
Comment 1 Aaron Digulla CLA 2005-10-25 03:43:59 EDT
This bug is now over a year old. What are the plans to implement it?
Comment 2 Douglas Pollock CLA 2005-10-25 14:34:40 EDT
This might be addressed for 3.2 
Comment 3 Michael Van Meekeren CLA 2006-04-21 13:12:27 EDT
Moving Dougs bugs
Comment 4 Paul Webster CLA 2007-04-05 19:03:31 EDT
Assigning to component owner
PW
Comment 5 Pawel Piech CLA 2008-08-19 16:31:40 EDT
I just submitted a patch for bug 244583 which would effectively address this request.  I would suggest to mark this bug as duplicate... and accept my patch :-)
Comment 6 Dani Megert CLA 2008-08-20 03:13:16 EDT
>I just submitted a patch for bug 244583 which would effectively address this
>request.  I would suggest to mark this bug as duplicate... and accept my patch
>:-)
Why did you open a new bug just to tell us to mark this existing bug as duplicate of yours?
Comment 7 Pawel Piech CLA 2008-08-20 11:17:53 EDT
(In reply to comment #6)
My apologies.  I only searched for similar bugs after I finished working on mine.  If you prefer, I can post my patch here and mark it as a dup.
Comment 8 Dani Megert CLA 2008-08-21 03:26:15 EDT
>If you prefer, I can post my patch here and mark it as a dup.
Yes, normally that's what we do because the old bug has most of the cc's. Only if the newer bug has much more information (e.g. steps to reproduce) than the older we mark the older as duplicate of the newer one.
Comment 9 Pawel Piech CLA 2008-08-21 16:57:24 EDT
Created attachment 110622 [details]
Path with proposed fix.

I'm attaching a patch which addresses this request.  Rather than letting the user choose either menu, or toolbar, or both, I only let the user "suppress" the toolbar contribution.  Implementing this feature as requested in this bug would have broken all kinds of API contracts and it would allow for a situation where actions are represented in the toolbar but not in the menu, which violates UI guidelines.

The main feature of this patch is a list of "suppressed toolbar" actions sets maintained with the perspective along with the "always on" and "always off" action sets.  The user can select which action sets should have their toolbar suppressed by selecting a checkbox in the Customize Perspective dialog under the toolbar contributions viewer.  The list of suppressed toolbar action sets is independent of the visible ones, so enabling or disabling action sets does not affect the state of the suppress toolbar check boxes.

To allow for perspectives to customize the action set presentation, I added a suppressToolbar attribute to the perspectiveExtension/actionSet extension point.  I also added a "visible" attribute which would allow a perspective to hide an action set that set its initially visible flag to true, though this is not strictly relevant to this bug.

Finally, to integrate this feature with the command framework, an additional context is added for each action set: "<action set id>$toolbar", so that commands contributed to a toolbar, and which use an action set for visibility, could respect this setting as well.  This feature would need to be better documented, though I'm not sure where.
Comment 10 Pawel Piech CLA 2008-08-21 16:58:32 EDT
Created attachment 110623 [details]
Screenshot of the customize perspective dialog with suppress toolbar feature.
Comment 11 Pawel Piech CLA 2008-08-21 17:00:38 EDT
*** Bug 244583 has been marked as a duplicate of this bug. ***
Comment 12 Eclipse Webmaster CLA 2019-09-06 15:30:47 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.