Bug 75651 - [content assist] Code assist blocked by background job
Summary: [content assist] Code assist blocked by background job
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-05 11:53 EDT by Michael Valenta CLA
Modified: 2019-09-04 01:57 EDT (History)
2 users (show)

See Also:


Attachments
VM trace of blocked code assist (683.93 KB, text/plain)
2004-10-05 11:56 EDT, Michael Valenta CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2004-10-05 11:53:34 EDT
I am trying to use build I20041005 but have come to the conclusion that the 
build is unusable for me. The problem is that, every minute or so, Eclipse 
becomes unresponsive. I have taken several snapshots and have already logged 
bug 75646 against JDT UI. One of the blockages I experienced was due to code 
assist being blocked, most likely by a background job. Not sure if this is one 
of the causes or just a symptom but I'm marking it as critical since, as I 
said, I cannot work in todays itegration build. I will attach a VM trace.
Comment 1 Michael Valenta CLA 2004-10-05 11:56:16 EDT
Created attachment 15008 [details]
VM trace of blocked code assist

I should add that this is NOT a deadlock. The system did recover. However, it
is not good to block the UI thread without some sort of user feedback.
Comment 2 Dani Megert CLA 2004-10-06 08:28:21 EDT

*** This bug has been marked as a duplicate of 75646 ***
Comment 3 Michael Valenta CLA 2004-10-06 09:22:41 EDT
This is not a duplicate of 75646. I'll downgrade the severity but this is a 
separate issue. Code that is running in the UI thread should not block on 
locks without providing feedback of some sort to the user. One option I can 
think of in this case would be to show the content assist window with some 
indication that it is waiting to be populated. I, as the user, could then 
decide to wait or to continue typing.
Comment 4 Dani Megert CLA 2004-10-06 13:23:10 EDT
The stack trace shows that quick fix/assist (Ctrl+1) has been used and not code
assist (Ctrl+Space). Is this correct?
Code assist does not need an AST to get its completions.
Comment 5 Michael Valenta CLA 2004-10-06 13:41:43 EDT
Probably. The key sequences have become second nature so it's hard to remember 
which I used.
Comment 6 Martin Aeschlimann CLA 2004-10-07 04:18:45 EDT
The quick assist and codeassist UI is the same and is done by the editor.

Collecting proposals in the background (= calling 
IContentAssistProcessor.computeCompletionProposals) should not be a problem 
for both of these features 
Comment 7 Dani Megert CLA 2004-10-07 05:03:46 EDT
Discussed with Martin: Quick Assist/Fix is more affected than Code Assist
because other plug-ins can provide "bad" assists or fixes while code assist is
under our fill control. Even without support from Platform Text Quick Assist/Fix
infrastructure could limit how much time is allowed to retrieve assists and
fixes from contributors. This should be done no matter whether Platform Text
provides better support in this area.
Comment 8 Lars Vogel CLA 2019-09-04 01:57:09 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it and remove the stalebug whiteboard tag. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--