Bug 75092 - [Themes] API Change: move RGBBlendColorFactory into new package
Summary: [Themes] API Change: move RGBBlendColorFactory into new package
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1 M3   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2004-09-27 11:24 EDT by Kim Horne CLA
Modified: 2004-09-27 14:05 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Horne CLA 2004-09-27 11:24:18 EDT 
I'd like to move the above mentioned class from org.eclipse.ui.themes into
org.eclipse.ui.themes.factories.  The themes package is going to expand as a
consequence of Bug 73085 and I'd like to keep things tidy.  Would this be
acceptable?  There should be few (if any) users of this class outside of
platform UI.
Comment 1 Kim Horne CLA 2004-09-27 11:24:48 EDT 
If this is acceptable, I'd like to get it in ASAP.
Comment 2 Jim des Rivieres CLA 2004-09-27 14:02:48 EDT 
Moving an API class between packages would be a breaking API change. The 
themes support was expose in 3.0, so it's reasonable to assume there will be 
users out there that we do no know about, and don't want to break either.
To make this kind of change non-breaking, you'd need to leave the old API 
class where it is, deprecate it, and subclass the new API class in the new API 
package (which isn't very tidy).

A separate API package just for factories doesn't sound like a particularly 
good idea. In general, I'd refrain from introducing a new API package unless 
there's a big win from doing so.
Comment 3 Kim Horne CLA 2004-09-27 14:05:42 EDT 
Fair enough.