Bug 74624 - Update to 3.0.1 fails
Summary: Update to 3.0.1 fails
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P1 major (vote)
Target Milestone: 3.1 M2   Edit
Assignee: Dorian Birsan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 74377 74941 75178 75515 75584 76166 77897 79501 81025 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-09-22 13:30 EDT by Ed Rouse CLA
Modified: 2005-05-28 19:05 EDT (History)
11 users (show)

See Also:


Attachments
potential fix for the install problem (24.15 KB, application/octet-stream)
2004-09-23 12:41 EDT, Dorian Birsan CLA
no flags Details
org.eclipse.update.core_R30_bug74624.patch (2.85 KB, text/plain)
2004-09-23 19:10 EDT, Konrad Kolosowski CLA
no flags Details
org.eclipse.update.ui_R30_bug74624.patch (537 bytes, text/plain)
2004-09-23 19:16 EDT, Konrad Kolosowski CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Rouse CLA 2004-09-22 13:30:24 EDT
As per dorian birsan, I am entering this bug. I have tried on several occasions
and several ways to update my Eclipse version 3.0.0 to 3.0.1. In every case the
outcome was the same, Eclipse will not run. I can make it run by deleting the
configuration directory, but then it thinks it is still in version 3.0.0 and
continues to ask me if I want to update. I also end up with both the 3.0.0 and
the 3.0.1 versions of the files being loaded and who knows what kind of problems
that will create.

I have entered a bug on the buildId not updating as a Runtime bug as per dorian
birsan. The bug # is 74621.

The update process takes 4-5 hours to download the files, there are one or more
files that are 'unsigned', the update processes fails many times with a dialog
to 'retry' and on one occasion it failed so bad I had to back up and start
again. Needless to say, with the overly long download times, I can only make one
update attempt per day. And I have done this 4 times.

I have even gone so far as to unzip 3.0.0 into C:\Eclipse which created the
eclipse directory. Started Eclipse and went immediately to Help -> Software
Updates -> Manage Configuration, clicked on Scan for Updates and followed
the instructions to start the download. 4.5 hours later, after 8 retries
and 1 complete restart, I get the 'Restart the Workbench' dialog box. Was
I successful?

No. Same problem as before. The config.ini still has the original build Id
in it and it still won't open.

here is the log file:

!SESSION Sep 21, 2004 15:37:31.225 ---------------------------------------------
eclipse.buildId=I200406251208
java.version=1.4.2_03
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.225
!MESSAGE Application error
!STACK 1
java.lang.RuntimeException: No application id has been found.
	at
org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:313)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:273)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:129)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:183)
	at org.eclipse.core.launcher.Main.run(Main.java:644)
	at org.eclipse.core.launcher.Main.main(Main.java:628)

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.241
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.compare_3.0.0/
[7] was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.241
!MESSAGE Bundle
update@/c:/Eclipse/eclipse/plugins/org.eclipse.core.resources.win32_3.0.0/ [11]
was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.241
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.help.ide_3.0.0/
[20] was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.241
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.help.ui_3.0.0/
[21] was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.241
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.jface_3.0.0/ [36]
was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.241
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.team.core_3.0.0/
[59] was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.241
!MESSAGE Bundle
update@/c:/Eclipse/eclipse/plugins/org.eclipse.team.cvs.ssh2_3.0.0/ [61] was not
resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.241
!MESSAGE Bundle
update@/c:/Eclipse/eclipse/plugins/org.eclipse.team.cvs.ssh_3.0.0/ [62] was not
resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.tomcat_4.1.30/
[66] was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.ui.console_3.0.0/
[68] was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.ui.forms_3.0.0/
[71] was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.ui.views_3.0.0/
[75] was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle
update@/c:/Eclipse/eclipse/plugins/org.eclipse.ui.workbench.compatibility_3.0.0/
[77] was not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle
update@/c:/Eclipse/eclipse/plugins/org.eclipse.update.core.win32_3.0.0/ [82] was
not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle
update@/c:/Eclipse/eclipse/plugins/org.eclipse.update.scheduler_3.0.0/ [84] was
not resolved.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.pde.build_3.0.1/
[89] was not resolved.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Missing required bundle org.eclipse.update.core_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Missing required bundle org.apache.ant_0.0.0.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.pde.core_3.0.1/
[90] was not resolved.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Missing required bundle org.eclipse.core.resources_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Missing required bundle org.eclipse.jdt.core_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Missing required bundle org.eclipse.team.core_0.0.0.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Bundle
update@/c:/Eclipse/eclipse/plugins/org.eclipse.pde.runtime_3.0.1/ [91] was not
resolved.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Missing required bundle org.eclipse.ui_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.256
!MESSAGE Missing required bundle org.eclipse.ui.views_0.0.0.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.pde.ui_3.0.1/
[93] was not resolved.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.ui.ide_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.ui.views_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.jface.text_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.ui.workbench.texteditor_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.ui.editors_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.core.resources_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.debug.core_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.debug.ui_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.help.base_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.jdt.core_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.jdt.debug.ui_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.jdt.launching_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.jdt.ui_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.pde_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.pde.build_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.search_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.team.core_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.ui_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.update.core_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.ui.forms_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.ant.ui_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.jdt.junit_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.ui.intro_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.ui.cheatsheets_0.0.0.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.pde_3.0.1/ [94]
was not resolved.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.pde.core_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.core.resources_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.jdt.core_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing required bundle org.eclipse.text_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing optionally required bundle org.eclipse.ui.intro_0.0.0.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.272
!MESSAGE Missing optionally required bundle org.eclipse.ui.cheatsheets_0.0.0.

!ENTRY org.eclipse.osgi Sep 21, 2004 15:37:31.538
!MESSAGE Bundle update@/c:/Eclipse/eclipse/plugins/org.eclipse.sdk_3.0.1/ [95]
was not resolved.
!SUBENTRY 1 org.eclipse.osgi Sep 21, 2004 15:37:31.538
!MESSAGE Missing required bundle org.eclipse.ui_0.0.0.
Comment 1 Dorian Birsan CLA 2004-09-22 13:42:51 EDT
It looks like we've found what the problem is:
as lots of plugins are being downloaded, and eclipse site is very slow, 
sometimes the connect() fails and the IOException is masked, so the user is 
not prompted to retry downloading. As such, downloading proceeds with the next 
plugin.
What you end up with is an install with some plugins missing, and then things 
just break.
Comment 2 Pascal Rapicault CLA 2004-09-22 14:20:29 EDT
*** Bug 74377 has been marked as a duplicate of this bug. ***
Comment 3 Jens Scheffler CLA 2004-09-23 02:16:14 EDT
Okay,
so as the description says I assume that the AutoUpdate was ncot succsessful.
How can I try to repaitr my installation?
Re-Do the AutoUpdate or unzip a fresh 3.0.1 into the corrupt installation?
Comment 4 Dorian Birsan CLA 2004-09-23 10:43:19 EDT
I think unzipping a fresh 3.0.1 on top would work, but restart with -clean:
eclipse.exe -clean
Comment 5 Markus Schaber CLA 2004-09-23 12:26:21 EDT
But will this unzipping and starting with -clean keep my config and my installed 
plugins? (I run eclipse sdk with gtk on linux)

Comment 6 Markus Schaber CLA 2004-09-23 12:29:13 EDT
And for the slow downloads - would it be possible to create mirrors and send 
http redirects so the auto update works with mirrors?
Comment 7 Dorian Birsan CLA 2004-09-23 12:41:42 EDT
Created attachment 14745 [details]
potential fix for the install problem

This Feature.class file should replace the one in
org.eclipse.update.core_3.0.0/updatecore.jar.
It may provide a fix to the update problems described in this bug and related
bugs. I will do more tests, but if someone can give it a try please let me know
if this helps at all. Thanks.
Comment 8 Dorian Birsan CLA 2004-09-23 12:47:20 EDT
I've been told that sometimes binary attachments to a bug don't work well, so 
I'd suggest using the above attachment in a test only eclipse.
Comment 9 Konrad Kolosowski CLA 2004-09-23 16:01:10 EDT
Here is what's happening:
SDK feature includes other features like Platform and JDT.
All plugins for Platform are downloaded.
Platform plug-ins and feature is installed (copied to plugins dir).
Let's say a random connection failure occurs while downloading some JDT plug-
in.
Since SDK must be installed as a whole, the Platform plug-ins and feature are 
removed.
Question to retry.  User clicks yes (downloaded files for platform and jdt are 
preserved).
Platform is feature is installed again, but this time all its plug-ins are 
skipped because InstallRegistry.getInstance().isPluginJustInstalled
(pluginsToInstall[i]) evaluates to true.

JDT plug-ins that are missing are redownloaded and installed correctly.

We end up with Installation that is missing all plug-ins belonging to Platform 
feature.

Possible places for a quick fix (I have not tried or evaluted them for 
regressions):
Add a call InstallRegistry.unregisterPlugin(IPluginEntry pluginEntry) to 
SiteFilePluginContentConsumer.cleanup
or
call InstallRegistry.cleanup() from InstallWizard.perfromFinish() before 
continuing to retry.
Comment 10 Dorian Birsan CLA 2004-09-23 16:17:40 EDT
The attachment has a fix for precisely the problem you describe.
The fix basically unregisters the "justInstalledPlugins" if the feature 
install did not succeed, so they will be re-installed next time (on retry).
Comment 11 Konrad Kolosowski CLA 2004-09-23 17:15:12 EDT
The fix does not correct this problem, because it unregisters 
justInstalledPlugins for a feature that just failed downloading (it had no 
plug-ins installed yet).
The feature that got installed prior, does not get its plug-ins unregistered, 
but the feature and the plug-ins are deleted from the system.

The fix is still valuable as it may correct another (rare, but possible) 
failure scenario - plug-ins missing if local disk IO error when installing non 
nested features.
Comment 12 Dorian Birsan CLA 2004-09-23 18:30:10 EDT
Yes, nested features are installed before the parent feature, and if the 
parent feature fails, the nested features are cleanup but 
the "justInstalledPlugins" are not cleanup, so on retry they are not 
reinstalled (but they should).
Comment 13 Konrad Kolosowski CLA 2004-09-23 19:10:32 EDT
Created attachment 14754 [details]
org.eclipse.update.core_R30_bug74624.patch

Proposed, cumulative patch to org.eclipse.update.core 3.0 with:
Dorian's change to Feature to ensure deleted plugins for the currently
installing are installed again.
My change to SiteFilePluginContentConsumer to ensure that deleted plug-ins for
other features in the nested feature hierarchy are installed again.
Comment 14 Konrad Kolosowski CLA 2004-09-23 19:16:07 EDT
Created attachment 14755 [details]
org.eclipse.update.ui_R30_bug74624.patch

Proposed, patch to org.eclipse.update.ui 3.0 with my change to InstallWizard to
ensure that plug-ins installed in previous running of the wizard (independent
features that did not require workbench restart) are not deleted when
installation of a feature in the current wizard session fails.
Comment 15 Konrad Kolosowski CLA 2004-09-23 21:22:53 EDT
Ignore the patch to update.ui in attachement 14755.  The problem from comment 
#14 does not exist.  I was seeing things.

Only attachement 14754 is needed.  I have tested upgrading 3.0 to 3.0.1 with 
simulated network problems, and under debugger.  Upgrade worked.
Comment 16 Dorian Birsan CLA 2004-09-23 21:33:10 EDT
fix released in both M2 (will ask Sonia for a rebuild) and in the 3.0 
maintenance stream (so 3.0.2 will pick it up)
Comment 17 Pascal Rapicault CLA 2004-09-24 09:53:56 EDT
*** Bug 74941 has been marked as a duplicate of this bug. ***
Comment 18 Thomas Watson CLA 2004-09-24 10:13:12 EDT
Dorian, does this mean an update to 3.0.2 from 3.0.1 can fail since the fix did 
not make it into 3.0.1?
Comment 19 Dorian Birsan CLA 2004-09-24 10:26:56 EDT
Tom, if the network connections are bad (like we've encountered recentely on 
eclipse.org) then yes, the update may fail.

If this bug is critical, perhaps we can provide a patch (that will only 
contribute the fix for update), which will have a higher chance of being 
updated successfully, and have 3.0.2 pre-req the patch.
Comment 20 Dorian Birsan CLA 2004-09-28 11:05:06 EDT
*** Bug 75178 has been marked as a duplicate of this bug. ***
Comment 21 Dorian Birsan CLA 2004-10-02 13:06:07 EDT
*** Bug 75515 has been marked as a duplicate of this bug. ***
Comment 22 Dorian Birsan CLA 2004-10-04 18:32:36 EDT
*** Bug 75584 has been marked as a duplicate of this bug. ***
Comment 23 Dorian Birsan CLA 2004-10-20 22:12:13 EDT
*** Bug 76166 has been marked as a duplicate of this bug. ***
Comment 24 Dorian Birsan CLA 2004-11-04 16:19:27 EST
*** Bug 77897 has been marked as a duplicate of this bug. ***
Comment 25 Dorian Birsan CLA 2004-11-25 11:58:36 EST
*** Bug 79501 has been marked as a duplicate of this bug. ***
Comment 26 Dorian Birsan CLA 2004-12-14 21:26:52 EST
*** Bug 81025 has been marked as a duplicate of this bug. ***
Comment 27 Enver Haase CLA 2005-05-28 14:05:05 EDT
This bug is far from being "RESOLVED FIXED". Please re-open.
I had the very same problem, upgrading from build M200409161125 which
I think is 3.0.1 to 3.0.2 left me with an unusable Eclipse and forces
me to re-install everything-- over a cellphone :(

Googling for the error message yields about 10 hits
where people are discussing that same problem.

Why is not the "updater" component updated first? This is the
way IBM Software Developer or IBM Software Architect works---
which are spin-offs of Eclipse.

Thanks!
--Enver
Comment 28 Enver Haase CLA 2005-05-28 14:08:06 EDT
I forgot to mention: I run Linux with the 1.4 blackdown JRE --- so it's not
only a Win2k problem.

//Enver