Bug 74319 - [Preferences] Some preferences aren't persisted on shutdown
Summary: [Preferences] Some preferences aren't persisted on shutdown
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P1 critical (vote)
Target Milestone: 3.1 M2   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 74315 (view as bug list)
Depends on: 74341
Blocks:
  Show dependency tree
 
Reported: 2004-09-20 12:17 EDT by Douglas Pollock CLA
Modified: 2004-09-23 14:17 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Pollock CLA 2004-09-20 12:17:16 EDT 
I200409200800 (JXE), GTK+ 2.4.9, KDE 3.3, Linux 2.6.8.1 
 
Some preferences are not persisted on shutdown.  Confirmed on all platforms: 
text preferences.  Possibly also show intro view, prompt on exit, etc. 
 
Setting this as critical, as I'm not sure if this data is lost or simply 
ignored.  If it is just ignored, then downgrade to major.
Comment 1 Kim Horne CLA 2004-09-20 12:29:06 EDT 
*** Bug 74315 has been marked as a duplicate of this bug. ***
Comment 2 Kim Horne CLA 2004-09-20 12:32:32 EDT 
The first line of Plugin.savePluginPreferences() checks to see if the
preferences need saving.  The preference store is not being marked as dirty
despite writes to it from the preference page.
Comment 3 Markus Keller CLA 2004-09-20 12:44:43 EDT 
Steps to reproduce in I20040920-0800 alone:
- Start I20040920-0800 with a new workspace
- Change Basic > Dialog Fonts and  > Text Font
- Exit and restart eclipse -> changes gone.

Steps when switching from I20040914-0800 to I20040920-0800:
- Have a I20040914-0800 workspace with changed fonts
- Exit and start same workspace with I20040920-0800
-> Font settings are not respected, although I never opened the Preferences dialog.
Comment 4 Tod Creasey CLA 2004-09-20 13:09:28 EDT 
The check Kim is talking about is only necessary in the backwards 
compatability story. I'll see why the new preferences are not being saved.
Comment 5 Tod Creasey CLA 2004-09-20 14:45:36 EDT 
There are a couple of problems here

1) We were broadcasting changes for default as well as preferences
2) We were not saving the store when the preference dialog closed. This is not 
required generally but a good safety thing
3) savePreferenceStore() in Plugin only saves the backwards compatibility 
layer but not the new OSGI layer. DJ will log a seperate report for this.
Comment 6 Tod Creasey CLA 2004-09-20 14:55:43 EDT 
I have fixed items 1) and 2) in the ScopedPreferenceStore
Comment 7 Tod Creasey CLA 2004-09-21 11:39:05 EDT 
Verified in 200409210800.
Comment 8 Tod Creasey CLA 2004-09-23 10:26:29 EDT 
Reopening to reverify on 20040923-1200 as we have had to rollback changes.
Comment 9 Tod Creasey CLA 2004-09-23 10:27:04 EDT 
Marking fixed so it is on the verification pass.
Comment 10 Tod Creasey CLA 2004-09-23 14:17:26 EDT 
Verified in 20040923-1200