Bug 74054 - [Actions] Ignore white space does not always work with Compare with Each Other
Summary: [Actions] Ignore white space does not always work with Compare with Each Other
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2004-09-16 07:41 EDT by Oyvind Harboe CLA
Modified: 2022-01-20 02:02 EST (History)
1 user (show)

See Also:


Attachments
Shows ignore whitespace checked, but compare still shows area as differing... (256.91 KB, image/pjpeg)
2004-09-16 07:42 EDT, Oyvind Harboe CLA
no flags Details
The treenode should not be created when ignore whitespace is turned (1.01 KB, patch)
2004-12-09 08:06 EST, Oyvind Harboe CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oyvind Harboe CLA 2004-09-16 07:41:55 EDT
I've been using Eclipse for a while(since 2.0) and I've always struggled with 
getting Eclipse to ignore differenes in whitespace when comparing.

There should be a much more obvious way to tell Eclipse to ignore whitespace 
during compare that *works*. 

See attached picture for an example.


Øyvind
Comment 1 Oyvind Harboe CLA 2004-09-16 07:42:41 EDT
Created attachment 14565 [details]
Shows ignore whitespace checked, but compare still shows area as differing...
Comment 2 Andre Weinand CLA 2004-09-16 08:26:36 EDT
The attached picture shows a conflict. Without seeing the ancestor, it is impossible to learn anything 
about whitespace. 
Comment 3 Oyvind Harboe CLA 2004-09-16 08:35:42 EDT
>The attached picture shows a conflict. Without seeing the ancestor, it is 
>impossible to learn anything about whitespace. 

I don't understand what you mean, could you clarify?

I see lines that do not differ at all(possibly in whitespace) that are marked 
as "conflicting"(i.e. red). This is a mystery to me.

Øyvind

Comment 4 Andre Weinand CLA 2004-09-16 08:46:32 EDT
Please open the third ancestor pane. It'll show the reason why you have a conflict.
You can open the ancestor with the left most button in the Text Compare's local toolbar.
Comment 5 Oyvind Harboe CLA 2004-12-09 08:06:30 EST
Created attachment 16488 [details]
The treenode should not be created when ignore whitespace is turned

If only whitespace differs, do not create the tree node in the compare view,
team synchronize, etc.
Comment 6 Oyvind Harboe CLA 2007-09-06 04:10:57 EDT
I'd like to request that the priority of this one is bumped...
Comment 7 Michael Valenta CLA 2007-09-07 12:43:30 EDT
Can you provide a set of steps to reproduce the problem you are seeing (i.e. ignore whitespace works for me)? It would also be helpful if you could provide 2 (or three if necessary) file versions to reproduce the problem.
Comment 8 Oyvind Harboe CLA 2007-09-07 12:52:34 EDT
(In reply to comment #7)
> Can you provide a set of steps to reproduce the problem you are seeing (i.e.
> ignore whitespace works for me)? It would also be helpful if you could provide
> 2 (or three if necessary) file versions to reproduce the problem.


After some investigations it turns out that things have improved dramatically from 3.2 to 3.3 in this regard.

The actual file compare seems to work, but I need to double check that the structure compare does not show false positives when ignore white space + consider  file contents is enabled.
Comment 9 Oyvind Harboe CLA 2007-09-10 04:21:59 EDT
The only remaining problem in 3.3 is that the structure compare does not take file contents into account.

I.e. if there is a file that *only* differs in whitespace changes, it is still shown in the team->synchronize view as differing.

When double clicking on that file no differences are shown.


To reproduce:

1. Turn on ignore whitespace
2. Turn on consider file contents
3. Add a newline to the end of a text file
4. Run team->synchronize, the text file in (3) is shown as a changed.


This becomes a real problem when different text editors is fighting over what sort of newline to use(dos or Linux) as may be the case when using e.g. FPGA(eletronics/hardware) tools together with Eclipse.
Comment 10 Michael Valenta CLA 2007-09-10 08:50:50 EDT
The issue you mention is specific to CVS and is intended behavior. CVS does not have an option to ignore whitespace when committing so we need to show files that contain whitespace changes as outgoing changes (i.e. how can CVS differentiate the false changes you mention from intended changes). I'm marking this as worksforme since, from a Compare component standpoint, this issue appears to be resolved.

Having said that, I could envision a CVS feature that ignored line ending changes on commit (and hence, in the synchronize view). However, we don't have the cycles to work on such a feature. If you wanted to contribute a such a feature, we would be willing to accept a contribution.
Comment 11 Oyvind Harboe CLA 2007-09-13 02:15:28 EDT
(In reply to comment #10)
> The issue you mention is specific to CVS and is intended behavior. CVS does not
> have an option to ignore whitespace when committing so we need to show files
> that contain whitespace changes as outgoing changes (i.e. how can CVS
> differentiate the false changes you mention from intended changes). I'm marking
> this as worksforme since, from a Compare component standpoint, this issue
> appears to be resolved.
> 
> Having said that, I could envision a CVS feature that ignored line ending
> changes on commit (and hence, in the synchronize view). However, we don't have
> the cycles to work on such a feature. If you wanted to contribute a such a
> feature, we would be willing to accept a contribution.

This applies to Compare with -> Eachother, CVS is not involved.



Comment 12 Michael Valenta CLA 2007-09-13 09:50:50 EDT
Sorry about that. For Compare with Each Other, I agree that the issue mentioned in comment 9 is relevant.
Comment 13 Eclipse Webmaster CLA 2019-09-06 16:04:17 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 14 Eclipse Genie CLA 2022-01-20 02:02:33 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.