Bug 7320 - Next diff scrolls when going into current diff
Summary: Next diff scrolls when going into current diff
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-01-07 15:00 EST by Nick Edgar CLA
Modified: 2009-08-30 02:32 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2002-01-07 15:00:19 EST
Build 20011219

Sometimes when clicking on next diff, it scrolls when going into the details of 
the current diff.  This is confusing, since the major change to the screen 
makes it look like a different diff.

For example, I just made a change to org.eclipse.ui/messages.properties, where 
I changed
  BuildAction.operationMessage = Building:
to 
  BuildAction.operationMessage = 

On sync, it shows the change to the line at the top of the page.
When I hit the down arrow, it scrolls this line to the middle of the page and 
selects just the change area.
At first I thought this was another diff, not further details about the current 
one.
This file was already showing a conflict due to a different change somebody 
else made.  When I hit next, I thought that somebody else had made a change to 
an entry with the same name elsewhere in the file.
Comment 1 Andre Weinand CLA 2002-01-11 04:32:41 EST
I traced this down to an empty clientArea reported from the StyledText widget
in TextViewer.getVisibleLinesInViewport() called from 
TextViewer.internalRevealRange(). As a consequence getVisibleLinesInViewport() 
returns -1 which results in some bogus scrolling.

I have no idea why this is happening, however I added a workaround
in TextMergeViewer.reveal(MergeSourceViewer v, Position p) to detect this case
and avoid any errornous vertical scrolling.

Reassigned bug to Platform/UI/TextViewer.
Comment 2 Kai-Uwe Maetzel CLA 2002-06-05 15:26:25 EDT
More investigation post 2.0
Comment 3 Eclipse Webmaster CLA 2009-08-30 02:32:12 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.