Bug 72752 - [Perspectives] Failed on updating workbench menu after application install when all the perspectives are closed
Summary: [Perspectives] Failed on updating workbench menu after application install wh...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 71585 (view as bug list)
Depends on: 80725
Blocks:
  Show dependency tree
 
Reported: 2004-08-26 18:36 EDT by B. Chen CLA
Modified: 2019-09-06 16:17 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description B. Chen CLA 2004-08-26 18:36:50 EDT
If I closed all the perspectives on the workbench, and installed a Hello World 
application that would add a menu item to the menu bar. The workbench is not 
updated with the new menu item until I opened a perspective.

Maybe a separate bug, at the end of the application install, the install will 
prompt for user to reset perspective even when all the perspectives were 
closed.
Comment 1 Nick Edgar CLA 2004-08-27 08:39:33 EDT
What mechanism is used to add the menu item?  An action set with state="true"?
Normally the workbench hides all action sets when all perspectives are closed,
so I wouldn't expect a newly installed one to show up.

Richard discussed this with me earlier, and it sounds to me like this is a
result of your patch to the base to show action sets when no perspectives are
open.  If so, then this is something you need to fix in your patch.
Comment 2 B. Chen CLA 2004-08-27 16:21:02 EDT
We are using the Eclipse sample Hello World. The state is set to "true"

- <extension point="org.eclipse.ui.actionSets">
- <actionSet label="Sample Action Set" visible="true" 
id="Hello_World.actionSet">
- <menu label="Sample &Menu" id="sampleMenu">
  <separator name="sampleGroup" /> 
  </menu>
  <action label="&Sample Action" icon="icons/sample.gif" 
class="Hello_World.actions.SampleAction" tooltip="Hello, Eclipse world" 
menubarPath="sampleMenu/sampleGroup" toolbarPath="sampleGroup" 
id="Hello_World.actions.SampleAction" /> 
  </actionSet>
  </extension>

This problem could happen to any RCP workbench with Update manager. From the 
RCP workbench launch Install to install a Hello World application while all the 
perspectives are closed.

This problem occured without Richard's code.
Comment 3 Michael Van Meekeren CLA 2005-01-12 12:14:52 EST
kim, can you comment on whether you have visited this case?
Comment 4 Nick Edgar CLA 2005-01-12 12:33:43 EST
Until bug 80725 is addressed, no action sets are shown while all perspectives
are closed, so I would not expect a newly installed action set to show up, even
if it has visible="true".

Given this behaviour, how are you invoking Update (in the IDE, anyway, its
actions come in via an action set)?

I'll mark this bug as dependent on bug 80725 so that we can ensure the dynamic
update case works.
Comment 5 Kim Horne CLA 2005-01-12 13:05:09 EST
I'll look into the reset prompt.
Comment 6 B. Chen CLA 2005-01-14 18:05:49 EST
The bug 80725 which this bug is dependent on has been fixed, any progress in 
fixing this problem?
Comment 7 Steven Wasleski CLA 2005-01-17 12:47:01 EST
Beth, I don't believe bug 80725 has been fixed.

Kim and Nick, there are some that want this capability in 3.0.2, but to be 
honest, this sounds like it could be too big of a change for a patch release.  
One could argue this is an enhancement request.  What are you thoughts?  Is 
this even being considered for 3.0.2?
Comment 8 Nick Edgar CLA 2005-01-18 15:32:23 EST
No, this is really a feature enhancement, so it's not being considered for 3.0.2.
Comment 9 Steven Wasleski CLA 2005-01-18 16:20:48 EST
Thanks for the update.  That is what I thought.
Comment 10 Nick Edgar CLA 2006-02-02 13:35:04 EST
There are no plans to address this enhancement for Eclipse 3.2.
Action sets still are not shown when all perspectives are closed (enhancement 80725), so there is no need to show them when dynamically installed.

I don't know if there has been any change in the prompt to reset, or if that is even an issue for you.  If so, we may be able to address that for 3.2.
Comment 11 Eric Klingelberger CLA 2006-02-03 19:45:26 EST
(In reply to comment #10)
> There are no plans to address this enhancement for Eclipse 3.2.
> Action sets still are not shown when all perspectives are closed (enhancement
> 80725), so there is no need to show them when dynamically installed.
> 
> I don't know if there has been any change in the prompt to reset, or if that is
> even an issue for you.  If so, we may be able to address that for 3.2.
> 

In regards to 80725, the patch code that Richard Redpath wrote to process actionSets when there is no initial perspective rendered is fairly straightforward.  I realize there are other higher pressure items to get into 3.2, but it would be nice to get rid of this patch fragment code.  If there is any possibility of getting the fix for 80725 and 72752(this bug) into 3.2 I think it should be done.
Comment 12 Nick Edgar CLA 2006-02-06 11:04:17 EST
We can't apply Richard's patch as-is, because that would change the meaning of visible="true" for existing action sets, which they may not be prepared to handle.
Doug, is there enough support in there now for Eric to try the approach you suggested in bug 80725 comment 9?
Please follow up in bug 80725, since this bug covers just the update issues.
Comment 13 Douglas Pollock CLA 2006-02-06 11:12:00 EST
(In reply to comment #12)
> Doug, is there enough support in there now for Eric to try the approach you
> suggested in bug 80725 comment 9?

No.  If it will be ready at all for 3.2, it will be delayed until 3.2 M6.
Comment 14 Kim Horne CLA 2007-06-21 13:47:41 EDT
*** Bug 71585 has been marked as a duplicate of this bug. ***
Comment 15 Susan McCourt CLA 2009-07-09 19:21:58 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 16 Eclipse Webmaster CLA 2019-09-06 16:17:16 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.