Bug 72705 - [Themes] Allow selecting system colors for color preferences
Summary: [Themes] Allow selecting system colors for color preferences
Status: RESOLVED DUPLICATE of bug 54039
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 180942
Blocks:
  Show dependency tree
 
Reported: 2004-08-26 13:39 EDT by Ron Baldwin CLA
Modified: 2007-06-21 13:42 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Baldwin CLA 2004-08-26 13:39:56 EDT
For any color set in the preferences, you should be able to set system defined
colors, e.g. Window background, 3D Objects (Button Face), etc.  

This has (at least) two benefits:
1) It makes it easier to set colors.  Currently, to set a system color you have
to go to display preferences, look up the RGB values for the UI element you want
to match, then type the values into the color dialog.
2) If you run the same workspace from multiple machines with different color
settings, the colors will look wrong on all but the machine the colors were set
on.  In some cases, the mishmash can be distracting; in the worst case, it makes
UI elements difficult or impossible to read.
Comment 1 Kim Horne CLA 2004-08-26 19:15:30 EDT
This dialog is provided by the platform, IIRC.  Moving to SWT for comment.
Comment 2 Ron Baldwin CLA 2004-08-26 19:57:46 EDT
Yes, the color dialog is provided by the platform (at least on Windows). 
However, I don't think it necessarily has to go away to satisfy this request. 
You just need some way to pick a system color or use the existing dialog to pick
a arbitrary color.

Right now, we have a less than optimal solution where in some places system
colors are the defaults and you can only select them using a Reset button
(Workbench > Colors and Fonts) and other places where the only way to use a
system color is to hardwire the RGB (e.g. setting the code assist tooltip color
to window background).
Comment 3 Ron Baldwin CLA 2004-08-27 11:03:49 EDT
BTW, it would seem that this would fit nicely with the 3.1 themes of "simple to
use" and "rich client platform" and the plan item described in Bug 71124.
Comment 4 Veronika Irvine CLA 2004-08-27 12:23:34 EDT
The preferences page could pop up a dialog that has some pre-defined colours 
and then give the user the option to define their own colours.  Only when the 
user tries to define their own colour would you need to open the system colour 
dialog.

I believe this is what ron is asking for.  Moving back to the UI team since I 
don't think this is an SWT problem.
Comment 5 Ron Baldwin CLA 2004-08-27 15:15:20 EDT
Changed the summary to one that makes a bit more sense.
Comment 6 Kim Horne CLA 2005-08-22 15:29:27 EDT
Veronika: seems to me like he's asking for the ability to pick and choose from colours that are mapped to 
Windows UI elements.  We could create a custom dialog that had some pre-defined elements in place, but 
we have no way of determining the values of system colours outside those that map to SWT.COLOR 
constants.

*volly back*
Comment 7 Steve Northover CLA 2005-09-01 17:46:56 EDT
Go ahead and make the dialog for the color constants if you want.  Colors 
outside of these constants (such as "Window background, 3D Objects (Button 
Face") are Windows specific and won't be in the dialog.

For the constants that SWT provides, you can determine the RGB values for the 
system color using getRGB().  Not sure why you would need to do this?
Comment 8 Kim Horne CLA 2007-06-21 13:42:34 EDT

*** This bug has been marked as a duplicate of bug 54039 ***