Bug 72489 - [Dialogs] ErrorDialog resize behaviour should be improved
Summary: [Dialogs] ErrorDialog resize behaviour should be improved
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal with 2 votes (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 67773 104841 122698 133114 140453 169630 174567 189724 209637 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-08-24 05:57 EDT by Marcus Olk CLA
Modified: 2008-03-26 00:28 EDT (History)
15 users (show)

See Also:
susan: review? (Tod_Creasey)

Attachments
Screen shot of ErrorDialog resize flaws (36.90 KB, image/gif)
2004-08-24 05:58 EDT, Marcus Olk CLA 		no flags Details
proposed patch to ErrorDialog (773 bytes, patch)
2007-05-09 16:20 EDT, Susan McCourt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Olk CLA 2004-08-24 05:57:47 EDT 
The resize behaviour of the ErrorDialog lacks a few constraints:
- You can resize the dialog arbitrarily.
  A minimum size should be calculated dynamically to make sure that
  all components are visible.
- If visisble - the details field upper left position should be
  fixed and the field itself should resizes only.
Comment 1 Marcus Olk CLA 2004-08-24 05:58:45 EDT 
Created attachment 14145 [details]
Screen shot of ErrorDialog resize flaws
Comment 2 Tod Creasey CLA 2005-01-06 10:56:19 EST 
*** Bug 67773 has been marked as a duplicate of this bug. ***
Comment 3 Markus Keller CLA 2006-03-24 15:21:49 EST 
*** Bug 122698 has been marked as a duplicate of this bug. ***
Comment 4 Markus Keller CLA 2006-03-24 15:59:59 EST 
*** Bug 133114 has been marked as a duplicate of this bug. ***
Comment 5 Susan McCourt CLA 2006-06-06 15:26:49 EDT 
*** Bug 140453 has been marked as a duplicate of this bug. ***
Comment 6 Susan McCourt CLA 2006-06-06 15:27:25 EDT 
look at this for 3.3, there have been many bugs opened on this issue
Comment 7 Markus Keller CLA 2007-02-19 04:10:10 EST 
*** Bug 174567 has been marked as a duplicate of this bug. ***
Comment 8 Susan McCourt CLA 2007-05-01 18:56:24 EDT 
investigate during RC1
Comment 9 Susan McCourt CLA 2007-05-09 16:20:11 EDT 
Created attachment 66563 [details]
proposed patch to ErrorDialog

The attached patch fixes the vertical resize so that the details area grabs all the extra space.
Comment 10 Susan McCourt CLA 2007-05-09 16:24:32 EDT 
The code change to fix the vertical resize problem (which has been reported in many duplicate bugs) is trivial, but there may be downstream clients relying on this behavior.

ErrorDialog creates an empty dialog area (under the message area and above the button bar).  This area was grabbing vertical space.  However, there are many subclasses that override the creation of the ErrorDialog dialog area to add content to this area.  If they are calling super.createDialogArea() and adding content, they may be relying on the vertical space grab.

Tod and Markus, what are your thoughts?  This would be a nice polish fix for ErrorDialog but potentially "unpolishing" of subclasses and perhaps late to be changing this.  If we don't do it now, I can do it first thing in 3.4.
Comment 11 Tod Creasey CLA 2007-05-09 16:31:29 EDT 
I would feel better if we did this for 3.4. There are a lot of ErrorDialog subclasses this might affect.
Comment 12 Susan McCourt CLA 2007-05-09 23:26:15 EDT 
I've marked this 3.4 and will release this patch very early in the 3.4 cycle so that we can finally fix this bug.
Comment 13 Markus Keller CLA 2007-06-20 04:30:59 EDT 
*** Bug 189724 has been marked as a duplicate of this bug. ***
Comment 14 Markus Keller CLA 2007-06-20 04:31:13 EDT 
*** Bug 104841 has been marked as a duplicate of this bug. ***
Comment 15 Markus Keller CLA 2007-06-21 12:10:15 EDT 
*** Bug 110625 has been marked as a duplicate of this bug. ***
Comment 16 Susan McCourt CLA 2007-06-25 18:05:20 EDT 
Fixed in HEAD (3.4 Stream) > 20070625.
I'll post a heads up in platform-ui-dev to give a heads up to those who might have been relying on the old behavior.
Comment 17 Susan McCourt CLA 2007-06-28 17:04:00 EDT 
*** Bug 169630 has been marked as a duplicate of this bug. ***
Comment 18 Susan McCourt CLA 2007-08-07 16:19:14 EDT 
verified in WinXP, I20070807-0010
Comment 19 Susan McCourt CLA 2008-03-26 00:28:12 EDT 
*** Bug 209637 has been marked as a duplicate of this bug. ***