Bug 72327 - [WorkbenchLauncher] Workspace Launcher Dialog grows in width for long paths
Summary: [WorkbenchLauncher] Workspace Launcher Dialog grows in width for long paths
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Linux
: P5 minor (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed, helpwanted
Depends on:
Blocks:
 
Reported: 2004-08-19 22:57 EDT by Jonathan Ball CLA
Modified: 2007-12-11 13:31 EST (History)
3 users (show)

See Also:


Attachments
screenshot demonstrating the bug (19.10 KB, image/png)
2004-08-19 22:58 EDT, Jonathan Ball CLA
no flags Details
ChooseWorkspaceDialogPatch (1.45 KB, patch)
2007-10-25 04:21 EDT, Janusz Lembicz CLA
no flags Details | Diff
Corrected ChooseWorspaceDialogPatch (1.34 KB, patch)
2007-10-27 16:05 EDT, Janusz Lembicz CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Ball CLA 2004-08-19 22:57:38 EDT
In most cases, the default width of the Workspace Launcher provides a decent
amount of space to display the full path to a workspace.  However, in the case
that the path is exceptionally long, shouldn't the Workspace Launcher remain at
a constant width or have a maximum width that it will expand?  It currently
expands to a width such that the full path of the selected workspace will be
displayed.

Steps to reproduce:
1) Select a workspace with path that is very long in the Workspace Launcher.
2) Start Eclipse with that workspace.
3) Restart Eclipse and notice the width of the Workspace Launcher Dialog.
Comment 1 Jonathan Ball CLA 2004-08-19 22:58:46 EDT
Created attachment 14086 [details]
screenshot demonstrating the bug
Comment 2 Boris Bokowski CLA 2007-01-02 11:15:14 EST
Reassigning bugs to reflect changes in ownership.
Comment 3 Janusz Lembicz CLA 2007-10-25 04:21:07 EDT
Created attachment 81137 [details]
ChooseWorkspaceDialogPatch

Hi. I don't know is it is exactly what you've expected. I've limited number of characters that workspace path could have to 50. If it exceed 50 width of combo is set to 300. Feel free to change these numbers. If anything is wrong, let me know.
Comment 4 Kim Horne CLA 2007-10-26 08:45:59 EDT
This solution is somewhat problematic.  It's behaviour isn't well defined - your font size is super large it wont work at all.

Instead of restricting it based on the number of characters why not just set the width hint immediately to some reasonable number?  This will force the dialog to be a consistent size for every length of string.
Comment 5 Janusz Lembicz CLA 2007-10-27 16:05:34 EDT
Created attachment 81331 [details]
Corrected ChooseWorspaceDialogPatch

(In reply to comment #4)

You are right. I hope that new, although simpler solution is good enough.
Comment 6 Kim Horne CLA 2007-11-05 14:19:33 EST
Fix in head.  Thanks Janusz!
Comment 7 Kim Horne CLA 2007-12-11 13:31:19 EST
Verified in I20071211-0010