Bug 72322 - Provide Search drop down toolbar button rather than simple button
Summary: Provide Search drop down toolbar button rather than simple button
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Platform-Search-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 136397 207744 207829
Blocks:
  Show dependency tree
 
Reported: 2004-08-19 18:33 EDT by Klaus Wenger CLA
Modified: 2007-11-06 05:13 EST (History)
3 users (show)

See Also:


Attachments
Plug-in with suggested Search drop down toolbar button (6.53 KB, application/octet-stream)
2004-08-19 18:35 EDT, Klaus Wenger CLA
no flags Details
replaces the search action in the toolbar (6.75 KB, patch)
2006-04-12 08:48 EDT, Markus Schorn CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Klaus Wenger CLA 2004-08-19 18:33:04 EDT
It would be cool to replace the Search button of the Search toolbar/action set 
by a dropdown menu that lists all available pages. The default action of that 
drop down could be like the one of the currently existing button. The actions 
in the drop down list would reflect all registered search pages and open them 
directly. I found it a bit of a detour to have to navigate to the wanted page 
in the often out of range tabs of the search dialog. Some plug-ins don’t 
introduce toolbar buttons to directly access their search pages. I already 
coded the according action and descriptors and attached them to this feature 
request. If you like you can transfer the code into the Eclipse platform code 
base.
Comment 1 Klaus Wenger CLA 2004-08-19 18:35:07 EDT
Created attachment 14085 [details]
Plug-in with suggested Search drop down toolbar button

Please feel free to use the provided code. No legal strings attached.
Comment 2 Markus Keller CLA 2004-11-22 11:42:35 EST
Cool idea.
Comment 3 Markus Schorn CLA 2006-04-12 08:48:20 EDT
Created attachment 38395 [details]
replaces the search action in the toolbar

I have taken the proposed implementation and made it part of the search plugin,
cleaned up access to the search-page extension.

The patch replaces the action in the toolbar by the drop-down. The behaviour when pressing the drop-down remains to be the same as before, so this is a pure enhancement, offering direct access to the search-pages.
Comment 4 Martin Aeschlimann CLA 2006-04-12 10:59:58 EDT
Thanks Klaus and Markus!
I had a look at this with Erich and we agreed that this an intersting polish that we want to add to RC1.
We will have to see what's the reaction of teams on top. We will decide in RC3 and RC4 if it will stay in.

I modified the patch to filter the shown actions using the activity filter and reformated it to the JDT UI code style.

patch released > 20060412
Comment 5 Klaus Wenger CLA 2006-04-12 11:26:17 EDT
sweet, many, many thanks, guys!!!

just to give you some more arguments to defend adding this little but useful drop down: the company i work for provides a whole solution based on eclipse and thus also adds many search pages. when using the regular search toolbar button, i find myself scrolling for the right page a lot. the drop-down gets me to my searches right away with two short-range clicks.
Comment 6 Martin Aeschlimann CLA 2006-04-12 14:00:51 EDT
Sorry, we have to hold back the release due to bug 136397. The action is forced to load what is critical for the startup performance.
Comment 7 Martin Aeschlimann CLA 2007-10-29 06:58:01 EDT
Feature released as bug 136397 is fixed > 20071029
Comment 8 Martin Aeschlimann CLA 2007-10-29 14:27:44 EDT
I reopn this and wait for after M3: There are still remaining issues in bug 207744  and bug 207829
Comment 9 Martin Aeschlimann CLA 2007-11-06 05:13:30 EST
released > 20071106