Community
Participate
Working Groups
I added >1000 files to .cvsignore and the userinterface was unresponsive for ~60 seconds. The application was at 100% usage and the rest of windows was also stuck. Seems like adding to .cvsignore held up the Windows event loop or something.
Created attachment 14082 [details] shows unresponsive GUI during add to .cvsignore
I see two problems in this report 1) CVS is adding the ignores in a busy-cursor whereas it should be done in a progress monitor or, better yet, a user job. 2) In the screenshow provided, the add to ignore list is adding an entire hierarchy when adding the parents would be enough. Having said that, point 2 doesn't cause a problem since the .cvsignore file is properly added to each directory. Point 1 should be addressed by making the ignore action a user job that is run after OK is pressed on the ignore dialog.
I added the use of a background job but the problem still remains (but is less severe). The problem is that the CVS meta-data synchronizer does not batch changes for ignore files. Also, I noticed that removing an ignore from a parent will cause it's direct children to appear in the synchronize view but indirect descendants will not be readded.
Adding my name to the cc list as we are now tracking performance issues more closely. Please remove the performance keyword if this is not a performance bug.
Fix released to HEAD. UI is no longer blocked and reverting an ignore works deeply now.
Michael can you tell me the performance improvement this represents for an average page (so that we can show it on the performance page)?
The case stated in the original comment should now only take a few seconds and since it is in the background, the UI is not blocked at all.
Verified
