Bug 72167 - ProcessConsole should extend IOConsole
Summary: ProcessConsole should extend IOConsole
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1 M2   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-18 11:04 EDT by Kevin Barnes CLA
Modified: 2004-09-14 09:22 EDT (History)
3 users (show)

See Also:

Attachments
patch for o.e.ant.test.ui (4.40 KB, patch)
2004-08-27 16:46 EDT, Kevin Barnes CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Barnes CLA 2004-08-18 11:04:39 EDT 
ProcessConsole should extend the new IOConsole to take advantage of new features (improved fixed 
width, regex pattern matching, simplified hyperlinking...)
Comment 1 Darin Wright CLA 2004-08-20 13:51:31 EDT 
I'm also going to suggest that we add an extension point to register regular 
expressions for pattern match listeners, with delegates that are instantiated 
lazily when a match is found.

We may need a way to identify the "type" of console, for example "java" such 
that an extension can register for a specific type of output.
Comment 2 Kevin Barnes CLA 2004-08-27 16:46:30 EDT 
Created attachment 14230 [details]
patch for o.e.ant.test.ui
Comment 3 Kevin Barnes CLA 2004-08-27 16:47:21 EDT 
fixed in ProcessConsole and related classes.
Comment 4 Darin Wright CLA 2004-08-27 16:52:14 EDT 
Applied patch to Ant UI tests.
Comment 5 Kevin Barnes CLA 2004-09-01 14:23:32 EDT 
released new consolePatternMatchListener extension point. Reimplemented ConsoleLineNotifier using 
that extension point. Removed unused process console code from internal packages.

ProcessConsolePage is currently a subclass of IOConsolePage which is internal to console plugin. 
Leaving PR open to address with another new extension point (IConsolePageParticipant)..
Comment 6 Kevin Barnes CLA 2004-09-01 15:51:57 EDT 
marking as FIXED
Comment 7 Kevin Barnes CLA 2004-09-01 16:57:11 EDT 
FIXED wrong PR
Comment 8 Kevin Barnes CLA 2004-09-07 10:06:07 EDT 
replaced ProcessConsolePage with ProcessConsolePageParticipant
Comment 9 Kevin Barnes CLA 2004-09-07 10:06:32 EDT 
Darin, please verify
Comment 10 Darin Wright CLA 2004-09-14 09:22:21 EDT 
Verified.