Bug 72060 - [Presentations] Improve workbench placeholders
Summary: [Presentations] Improve workbench placeholders
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2004-08-16 16:30 EDT by Stefan Xenos CLA
Modified: 2012-11-06 11:33 EST (History)
2 users (show)

See Also:

Attachments
org.eclipse.ui.workbench (117.01 KB, patch)
2004-08-30 16:34 EDT, Cory Turner CLA 		no flags Details | Diff
org.eclipse.ui.tests (39.04 KB, patch)
2004-08-30 16:35 EDT, Cory Turner CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2004-08-16 16:30:26 EDT 
Currently, workbench placeholders are implemented using a special subclass of
LayoutPart. This is problematic because their public interface does not behave
the same as other LayoutParts, requiring instanceof checks wherever any
LayoutPart is used.

Placeholders should be implemented using a separate data structure from the
objects used to display real parts.
Comment 1 Cory Turner CLA 2004-08-30 16:34:13 EDT 
Created attachment 14271 [details]
org.eclipse.ui.workbench

I'm just going to post these here now where they're easily found. 

There are no known bugs right now, but state saving is still less than ideal.
Savestate adds placeholders for visible views. I've come to the conclusion that
with this implementation it has to be this way. The way it was previously done
was that restorestate adds placeholders instead. We could do this too but it
means using different tags for placeholders and views, and in the end, we still
need to create placeholders that weren't there before in order to show the
view.

Otherwise, this patch does solve a lot of bugs, and chops a lot of code out of
PerspectiveHelper.
Comment 2 Cory Turner CLA 2004-08-30 16:35:50 EDT 
Created attachment 14272 [details]
org.eclipse.ui.tests

Test suites for placeholders. Even if the new style placeholders are too high
risk to implement these tests should prove useful. Note that several of these
tests rightly fail with old style placeholders.
Comment 3 Stefan Xenos CLA 2005-05-11 18:58:05 EDT 
Sorry I didn't get this in for 3.1. It's still on my radar, though.
Comment 4 Paul Webster CLA 2006-09-28 11:00:29 EDT 
There are currently no plans to work on this feature.

PW
Comment 5 Denis Roy CLA 2007-06-22 09:32:41 EDT 
Changes requested on bug 193523
Comment 6 Eric Moffatt CLA 2012-11-06 11:33:04 EST 
We've moved on...