Bug 68250 - Throwing Focus to the EditorPart
Summary: Throwing Focus to the EditorPart
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0.1   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2004-06-22 18:29 EDT by Randy Hudson CLA
Modified: 2004-09-09 13:26 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Hudson CLA 2004-06-22 18:29:59 EDT 
Enable "Single click opens" option under workbench preferences.
Select on the same resource over and over (slowly) in the synchronize view.  
Every time you select, focus is thrown to the editor.  This makes it hard to 
use the keybindings in that view because it doesn't stay active.

Now try the same thing using ENTER.  Simply opening the outgoing change throws 
focus to the Editor.  This makes it hard to look at a bunch of changes using 
the keyboard only.  You must use CTRL+F7 to keep switching back to the View.
Comment 1 Randy Hudson CLA 2004-08-11 11:58:08 EDT 
I am increasing the severity. The effect of throwing focus when the synchronize 
view is a fast view is that the fast view is hidden.  This makes it really hard 
to glance at multiple incoming/outgoing changes.

Please consider fixing for 3.0.x
Comment 2 Andre Weinand CLA 2004-08-11 13:38:54 EDT 
It seems that the argument "keepfocus" of method 
OpenInCompareAction.openCompareEditor(...)
in package org.eclipse.team.internal.ui.synchronize.actions controls this behavior.
Currently it is always false. Setting it to true fixed the problem for me.

Moving to Team for comment.
Comment 3 Michael Valenta CLA 2004-08-16 14:46:09 EDT 
This is an easy fix.
Comment 4 Michael Valenta CLA 2004-08-16 14:49:22 EDT 
I have changed the open to use the OpenStrategy.activateOnOpen() hint. The fix 
has been released to both 3.1 and 3.0.1.
Comment 5 Jean-Michel Lemieux CLA 2004-09-09 13:26:52 EDT 
verified in rc2