Bug 67900 - [Viewers] Label provider return values need clarifying
Summary: [Viewers] Label provider return values need clarifying
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 3.1 M2   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2004-06-18 17:23 EDT by Nick Edgar CLA
Modified: 2004-09-22 08:35 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2004-06-18 17:23:13 EDT 
RC2

The Javadoc for the methods in ITableLabelProvider are missing @return tags.
Comment 1 Nick Edgar CLA 2004-06-18 17:28:46 EDT 
Trigger PR: bug 67870.

Actually, there is some inconsistency here.
Both getText and getImage in ILabelProvider are spec'ed to allow null return values.
But the viewers don't check for null.

ITableLabelProvider's methods should also allow null return values.

All viewers needs to be fixed up to check for null, and use the empty string
instead.
Comment 2 Tod Creasey CLA 2004-08-19 15:41:35 EDT 
I have clarified the javadoc but I still need to check the viewers.
Comment 3 Tod Creasey CLA 2004-08-19 16:40:03 EDT 
I have checked, fixed and released all of the uses of ILabelProvider in the 
platform that may have resulted in an NPE due to a null text.
Comment 4 Tod Creasey CLA 2004-09-22 08:35:23 EDT 
Verified in 20040921