Bug 65741 - [Progress] IDeferredWorkbenchAdapter#fetchDeferredChildren needs to handle errors better
Summary: [Progress] IDeferredWorkbenchAdapter#fetchDeferredChildren needs to handle er...
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks: 65008
  Show dependency tree
 
Reported: 2004-06-04 12:11 EDT by Jean-Michel Lemieux CLA
Modified: 2009-08-30 02:08 EDT (History)
0 users

See Also:


Attachments
Patch that extends IElementCollector with IErrorCollector (8.01 KB, patch)
2004-08-23 10:43 EDT, Michael Valenta CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Michel Lemieux CLA 2004-06-04 12:11:22 EDT
3.0 RC1
Current the caller of fetchDeferredChildren() always returns an OK status
meaning that fetching the children has been successful. There are cases when
exceptions will occur and the errors must be reported by the caller. 

The method should be changed to throw an exception. I don't think this change
will break implementers.
Comment 1 Tod Creasey CLA 2004-06-08 10:34:30 EDT
This would be an API change nonetheless as it is changing what can be returned.

Deferring.
Comment 2 Tod Creasey CLA 2004-06-28 11:27:25 EDT
Reopening now that 3.0 has shipped
Comment 3 Tod Creasey CLA 2004-08-20 10:15:47 EDT
I have changed it so that we can also return a CANCEL status.

Talking to Michael the greater issues seems to be a good way of logging errors.

It is possible to implement your own IElementCollector currently to do this 
but this will likely be something that is worth us providing generally 
(perhaps with a subtype of IElementCollector we add later).

I am going to mark this down in priority now as it is a feature request for us 
to provide something - we can discuss it further at a more convenient time for 
the Team team.
Comment 4 Michael Valenta CLA 2004-08-23 10:43:02 EDT
Created attachment 14121 [details]
Patch that extends IElementCollector with IErrorCollector

Here's a patch that extends IElementCollector with an interface that supports
error collection. It's pretty straight forward. The only undesirable I can see
is the use of instance of on the collector but I don't see a way around that
without breaking (or duplicating) API. Also, in the end, IElementCollector2 may
be a better name (than IErrorCollector) for the new interface since it follows
an already existing convenstion for this type of API extension.
Comment 5 Tod Creasey CLA 2006-04-07 11:37:44 EDT
There are currently no plans to work on this feature. Please reopen if you wish to continue on it
Comment 6 Denis Roy CLA 2009-08-30 02:08:38 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.