Bug 65577 - Save/Save All pop up assert window
Summary: Save/Save All pop up assert window
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2004-06-03 13:04 EDT by Ernest Pasour CLA
Modified: 2007-06-22 10:04 EDT (History)
0 users

See Also:


Attachments
the 3 tracebacks from the log (14.19 KB, text/plain)
2004-06-03 13:11 EDT, Ernest Pasour CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ernest Pasour CLA 2004-06-03 13:04:52 EDT
In rc1, I saw several asserts relating to my attempts to do a Save All and a
subsequent Save.

Basically, here's what I did (haven't tried to reproduce).

1. I had a bunch of files open, all saved, all compiled
2. ran organize imports on project.  This resulted in a bunch of files being
opened and left in modified state.  Also, some files that were already open were
modified.
3. I manually saved a couple of them and then tried File->saveall.  I got an
assert popup several times.  I don't know if it saved any of the files, but it
might have.  It definitely didn't not save more than a couple of them each time,
because I still had plenty left to save.  So I went through and saved them all
manually.  I also saw an assert with Save at a subsequent point while saving the
files, but I believe the file was successfully saved.

Later, I tried modifying a file manually and doing SaveAll, but did not see the
assert again.
Comment 1 Ernest Pasour CLA 2004-06-03 13:11:20 EDT
Created attachment 11549 [details]
the 3 tracebacks from the log

I think the 3 tracebacks are pretty much identical, even though one came from
Save, and the other two came from Save All.
Comment 2 Dani Megert CLA 2004-06-08 12:07:24 EDT
This bug looks similar to bug 5280 which we were not able to reproduce. We are
not able to reproduce this bug either using I200406072000. Please provide
further information:

- were there other errors in .log? If so, please attach them
- did you get this bug on plain RC1 or did you install other plug-ins?
- can you reproduce this bug? If so, please provide more detailed steps, e.g.
whether you have multiple open workbench windows
Comment 3 Ernest Pasour CLA 2004-06-09 10:52:30 EDT
I just saw this today on a pretty vanilla rc1 (only running a gc plugin).

I have 75 Java windows open.  They are a mixture of java and .class files, both
mine and from the eclipse sources.
I'm in the Java perspective.
From the Package Explorer, I selected one of my packages and did
source->organize imports from the context menu.  The package has 8 java files in
it, 4 of which were open.  Only two actually required import changes. 
The operation left both those files modified.  Does it always leave files
modified?  Maybe that's the first sign of problems?
I did File->Save all.  I got the assert.  (and that's the only new error in the log)
I did File->Save on one of the files and it saved without error.

I don't know what to tell you about reproducing other than a)try organize
imports on multiple files that require changes b)have a bunch of files open c)do
save all.  I'll have to create a dummy project and see if I can narrow down any
reproduction steps.
Comment 4 Ernest Pasour CLA 2004-06-09 11:13:10 EDT
OK, a little more info.

1. when I get the save all assert, 1 file *is* being saved each time.

2. I just saw it again with Organize Imports.  One thing I noticed was that I
went to File->Save all, and it wasn't enabled.  I switched to another random
.class editor file and the Save All was enabled properly. (Save and Save As were
also disabled initially).  About 10 files were modified by the operation, and
they showed up as modified in the window pull down list at the same time Save
All was disabled.  
Comment 5 Dani Megert CLA 2004-06-09 11:22:07 EDT
>Does it always leave files modified?
Yes, files that are open in the editor are left unsaved (to allow you Undo)

>I don't know what to tell you
- can you please try without the gc plug-in
- can you please try without having open class files
- do you use multiple workbench windows?
Comment 6 Ernest Pasour CLA 2004-06-09 13:55:28 EDT
I don't think I use multiple workbench windows, but I'm not sure what that means.

I'm trying in a new project with some dummy files, but I haven't had any luck yet.
Comment 7 Dani Megert CLA 2004-06-10 03:10:08 EDT
>I don't think I use multiple workbench windows, but I'm not sure what that means.
Instead of working just with one Eclipse window and 1..n perspectives you can
open additional windows by clicking Window > New Window
Comment 8 Ernest Pasour CLA 2004-06-10 07:16:19 EDT
Oh, okay.  No, I'm only working with 1 workbench window.
Comment 9 Dani Megert CLA 2007-06-22 09:58:48 EDT
Get rid of deprecated state.
Comment 10 Dani Megert CLA 2007-06-22 10:04:14 EDT
.