Community
Participate
Working Groups
RC1 The ordering of the menu items changed in the global search menu. The two action Occurrences in File and Exception Occurrences are placed as follows: - 2.1.3 at the bottom - M8 or M9: at top - a build between M9 and RC1: at the bottom - RC1: at top We haven't changed anything here in the plugin.xml file in JDT/UI. Can you please advice how we can get a stable ordering here
IMO this has to be addressed for 3.0
in the latest build (200406082000) the ordering is OK. Has anything change in the implementation or are we still vulnerable?
I just tried 2.1 - bottom M9 - bottom last night 200406082000 - bottom
I'm sure that I have seen M9 with the items at the top, so there must be another influencing factor - plug-in activation order?
Plugin activation order should not affect the order of action set actions. We process them in action set id order.
we have seen the problem again when we tried to fix bug# 66471. The underlying problem is described in bug# 155684, i.e., an action set that want to contribute to a menu contributed by another plug-in needs to redefine the target menu. The issue in this case is that the search menu defined in org.eclipse.search and the redefinition in org.eclipse.jdt.ui are not consistent. One separator is missing: <separator name="internalOccurrencesGroup"> </separator> This means depending on which search menu definition "wins" you get a different order. For 3.0 we will add this separator to the search menu in org.eclipse.search. Nick stated that the action sets are processed in action set ID order. If this is the case then I would have expected that this could also be fixed by prefixing the jdt.ui action set with "aaa", but this didn't help. I'll mark it for RC3 but the change will happen in org.eclipse.search, leaving the bug in org.eclipse.ui since this needs to be revisited after 3.0.
Erich once you have addressed the search component part of this fix, please update the milestone for 3.1
Here is a reproducable case that illustrates that the search menu appears in the wrong order: 1) start a fresh workspace 2) create a Java project, BUT stay in the resource perspective 3) create a java file (File>New>File) 4) the file is opened in the Java editor 5) Open the search menu -> the order is reverted, also the JUnit Referring Tests action is missing. Next step is to add the <internalgroup> to the search menu in org.eclipse.search.
Moving to Search for 3.0 work. Please move back to UI and mark for 3.1 when you are ready for us to continue.
added the missing separator: <separator name="internalOccurrencesGroup"/> fix reviewed by Dirk - released into 20040617* moving bug back to Platform UI
Looks like another dup of bug 15670.
I don't think we are going to get to this for 3.1
ccing doug. This might be something we can address with new commands work.
Moving Dougs bugs
Moving to 3.3
Assigning to component owner PW
This item has been fixed/superceded by the menu contribution mechanism - bug 154130
>This item has been fixed/superceded by the menu contribution mechanism - bug Please provide more details. Is it now fixed or not? If not, please explain what clients need to change in order to fix their code.
(In reply to comment #18) > >This item has been fixed/superceded by the menu contribution mechanism - bug > Please provide more details. Is it now fixed or not? In this case one menu contribution can define the menu structure, and one or more other contributions can be added. Clients that want the more precise ordering abilities will need to migrate to menu contributions/commands. I was planning on using bug 15670 to increase the adoption of menu contributions in the platform UI code so that others will be able to do the same thing for platform UI action sets. (this one was marked early on in our bug sweep ... I've taking to mark the later ones as WONTFIX since it requires a migration to the new code). PW
