Bug 64849 - [encoding] improve Container.getDefaultCharset performance
Summary: [encoding] improve Container.getDefaultCharset performance
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Rafael Chaves CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2004-05-31 17:29 EDT by Rafael Chaves CLA
Modified: 2004-06-10 15:54 EDT (History)
1 user (show)

See Also:

Attachments
profiler output for the second full-build in a session (134.37 KB, text/html)
2004-05-31 17:31 EDT, Rafael Chaves CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Chaves CLA 2004-05-31 17:29:37 EDT 
File.getCharset performance can be improved without much effort for the case the
information is cached (common scenario)

In this scenario, we spend too much time traversing the tree way down to the
root (checking whether every resource exists) and retrieving the same node in
the project preferences context.
Comment 1 Rafael Chaves CLA 2004-05-31 17:31:58 EDT 
Created attachment 11334 [details]
profiler output for the second full-build in a session

Interest call is:

0.33% - 584 ms - org.eclipse.core.internal.resources.File.getCharset()
Comment 2 Rafael Chaves CLA 2004-05-31 17:32:57 EDT 
Moving back to Inbox to ensure DJ sees it.
Comment 3 DJ Houghton CLA 2004-05-31 17:51:20 EDT 
You can always add me to the CC or send me an email too. :-)
Comment 4 Rafael Chaves CLA 2004-06-10 15:54:28 EDT 
Fixed. Reviewed by DJ. Released to HEAD.