Bug 64485 - [ViewMgmt] removeFastView is called more frequently than necessary
Summary: [ViewMgmt] removeFastView is called more frequently than necessary
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Stefan Xenos CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2004-05-27 22:45 EDT by Nick Edgar CLA
Modified: 2005-05-10 17:56 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2004-05-27 22:45:25 EDT
M9 build

While looking at another problem, I noticed that WorkbenchPage.removeFastView is
getting called more frequently than necessary, e.g. when opening a regular view.
This is potentially expensive: it always updates the fastview bar and fires a
CHANGE_FAST_VIEW_REMOVE event.

Workaround is to add:
		if (!isFastView(ref)) {
		    return;
		}
early in the method.
Comment 1 Tod Creasey CLA 2005-03-07 11:57:17 EST
Adding my name to the cc list as we are now tracking performance issues more
closely. Please remove the performance keyword if this is not a performance bug.
Comment 2 Mike Wilson CLA 2005-04-21 15:03:39 EDT
Has this been fixed?
Comment 3 Stefan Xenos CLA 2005-04-22 01:29:24 EDT
It has indeed. Looks like it has been for some time.
Comment 4 Stefan Xenos CLA 2005-05-10 17:56:38 EDT
Verified in I20050510-0010