Bug 64363 - [Progress] Progress View Remove All Terminated Tasks using disabled icon
Summary: [Progress] Progress View Remove All Terminated Tasks using disabled icon
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Prakash Rangaraj CLA
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2004-05-27 11:41 EDT by Randy Hudson CLA
Modified: 2009-07-13 10:07 EDT (History)
3 users (show)

See Also:


Attachments
Inconsistent icons (15.97 KB, image/gif)
2004-06-21 10:42 EDT, Randy Hudson CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Hudson CLA 2004-05-27 11:41:16 EDT
The "Remove All Terminated Tasks" action on the progress view's menu and local 
toolbar is using the B&W disabled icon instead of the colored one.
Comment 1 Andre Weinand CLA 2004-05-27 15:06:35 EDT
Why do you think?
Comment 2 Randy Hudson CLA 2004-05-27 15:24:26 EDT
The toolitem's border rollover indicates that the action is enabled.  So does 
the menuitem's text.
Comment 3 Andre Weinand CLA 2004-05-27 17:10:56 EDT
Are you assuming that the enabled icon would be more colorful?
It isn't.
See Search result view.
Comment 4 Randy Hudson CLA 2004-05-28 10:46:06 EDT
Why is a red 'X' gray (that sounded funny)?  The icon looks disabled.  It is 
also inconsistent with the "X" icon on the Tasks View.
Comment 5 Michael Van Meekeren CLA 2004-06-21 09:53:00 EDT
closing
Comment 6 Randy Hudson CLA 2004-06-21 10:42:29 EDT
Created attachment 12566 [details]
Inconsistent icons

The Tasks View uses red, while search, debug use gray, which looks disabled. 
Especially when the user has learned that the red icon means enabled.
Comment 7 Andre Weinand CLA 2004-06-22 08:54:32 EDT
The problem seems the Task View, not the Progress View.
Comment 8 Randy Hudson CLA 2004-06-22 11:14:34 EDT
> The problem seems the Task View, not the Progress View

So you admit there is a problem, then resolve as WONTFIX? The problem is 
consistency. Why do you think the Red Xs are wrong and the gray is correct?
Comment 9 Andre Weinand CLA 2004-06-22 11:16:41 EDT
Since gray is the majority.
Comment 10 Randy Hudson CLA 2004-06-22 11:51:46 EDT
Red is the majority if you look at any other program which displays an X icon 
meaning delete.  Please switch the gray icons to red.
Comment 11 Andre Weinand CLA 2004-06-22 11:57:58 EDT
This is no longer my problem.
Comment 12 Sebastian Davids CLA 2004-12-03 12:09:33 EST
Also:

The action should be disabled when there are no tasks to be removed and enabled
when there are.

This is not in Build id: 200412011139.
Comment 13 Michael Van Meekeren CLA 2004-12-03 13:47:20 EST
adding Andrée
Comment 14 Andrée Proulx CLA 2004-12-03 16:51:06 EST
I thought I had already responded to this. Perhaps in another bug.
Delete is red, remove is black. This is the semantic we have decided and closed 
on last June.

re: #12 This problem is not related to the color of the icon, but to its logic. 
Defering to Michael.
Comment 15 Randy Hudson CLA 2004-12-03 18:01:50 EST
If the X were black I wouldn't have opened this bug. But I don't understand why 
two actions having different text labels implies that they must have both a 
unique shape and color. "Cancel Task" is a red square with an outline.  Guess 
what, so is "Terminate".  Semantically they are different, but using the same 
icon or at least the same color makes perfect sense there, and here.
Comment 16 Randy Hudson CLA 2006-04-14 09:46:51 EDT
The last comment refers to operations in the progress view, task meaning background task, not tasks view.
Comment 17 Susan McCourt CLA 2009-07-09 19:30:24 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 18 Prakash Rangaraj CLA 2009-07-10 08:37:40 EDT
(In reply to comment #15)
> If the X were black I wouldn't have opened this bug. But I don't understand why 
> two actions having different text labels implies that they must have both a 
> unique shape and color. "Cancel Task" is a red square with an outline.  Guess 
> what, so is "Terminate".  Semantically they are different, but using the same 
> icon or at least the same color makes perfect sense there, and here.

Following comment #14, Delete and Remove are two different things, you "delete" a file and "remove" a search result. The basis of the color denotes the destructiveness (if that is the right word) of the operation. User has to be more careful for delete than remove. Thats the idea of adding red colored icon.

Same applies for canceling a task or terminating a process. They are in red, because the user is "warned" to be a little careful on clicking on it. We don't have to warn the user for the "Remove Terminated" button.

On the inconsistency of the icons in comment #6, the task view doesn't have the icon now. Debug/Progress/Search all are consistently looking with the gray icon for the remove operations. Nothing to be done here.

As per the bug goes, "Remove Terminated" is a remove operation rather than delete operation and so the black icon is the right one. Marking it as won't fix.
Comment 19 Sebastian Davids CLA 2009-07-12 04:00:05 EDT
opened bug 283235 for comment 12
Comment 20 Randy Hudson CLA 2009-07-13 10:07:10 EDT
Again, the icon is not black.  It's RGB value (#888888) is closer to white.