Community
Participate
Working Groups
When UI and IDE are loading the icons, they are looking up the bundle for every icon they are trying to load. Looking up a bundle is not specially slow but is not the fastest operation either, therefore it could be great if you could lookup the bundle once and use it to load all the icons. Doing that will probably slightly improve the startup time.
Created attachment 11129 [details] Patch for the described problem The patch provided only fixes the problem in IDE.
I applied the patch to "ide" and observed Pascal's changes. As he stated, his fix allows the bundle to be looked up once for all icons. I checked out "platform-ui" and searched (Java method search) "getPlugin()" to try and flag similar issues. Here are the instances I found that involve images (they are all in "org.eclipse.ui.ide") - WizardStepGroup#createImage(String iconFileName) - BookmarkNavigator#getImageDescriptor(String relativePath) - FrameAction#getImageDescriptor(String relativePath) - ImageFactory#create(String path) - ResourceNavigatorActionGroup#getImageDescriptor(String relativePath) - MarkerUtil#createImageDescriptor(String relativePath) - FileSystemExportWizard#getImageDescriptor(String relativePath) - FileSystemImportWizard#getImageDescriptor(String relativePath) - ZipFileExportWizard#getImageDescriptor(String relativePath) - ZipFileImportWizard#getImageDescriptor(String relativePath) Some of the above are not referenced very often and/or do not affect the start up time. They might not be worth changing. Tod, are there other classes (or searches) you can think of I might have omitted?
The other main one is WorkbenchLabelProvider which also happens on startup. As I optimized this last week there is likely nothing else to be done there. Ines please attach yoiur WorkbenchAdvisor patch
Ines has checked - I will verify and we will address this in RC2.
Patch released for build > 20040608
Verfied in 20040609
