Bug 63692 - [projection][rulers] Not all annotation types in folded region rendered in rulers
Summary: [projection][rulers] Not all annotation types in folded region rendered in ru...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 minor with 6 votes (vote)
Target Milestone: 3.6 M5   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 65774 66896 71758 73133 76650 82348 98367 103114 109314 113392 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-05-24 11:11 EDT by Markus Keller CLA
Modified: 2010-01-26 04:37 EST (History)
14 users (show)

See Also:


Attachments
Work in progress (using internal code) (1.78 KB, text/plain)
2009-09-14 09:36 EDT, Dani Megert CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2004-05-24 11:11:39 EDT
3.0M9

- activate code folding and find a text range with annotations (e.g. QuickDiff
changes or task tags)
- collapse the region

=> The (folded) annotations are not rendered in the overview ruler. However, if
you hover over the right position in the overview ruler, the annotation message
is shown in a tooltip.
=> expected: annotations still rendered
Comment 1 Kai-Uwe Maetzel CLA 2004-06-03 08:29:50 EDT
This is on purpose. The thumb reflects the visible region of the viewer. When 
showing all annotations we'd loose that relation. Also, it's in sync with the 
segmented mode. No action for 3.0
Comment 2 Markus Keller CLA 2004-06-03 08:58:56 EDT
I agree that the thumb reflects the visible region of the viewer and I also
think it's correct to collapse a collapsed region in the overview ruler too. 
However, errors and warnings are already shown in a combined annotation when the
region is collapsed.

What I suggest is that the other annotations should likewise be rendered in the
overview ruler at the position of the top line of the folded region. They are
already there when you hover over the right position - only the colored
rectangle is missing.

I agree this not critical for 3.0, but it would be nice to see that there is
something in a collapsed region (e.g. changes or todos in a nested type) with a
quick glance at the overview ruler.
Comment 3 Markus Keller CLA 2004-06-11 06:05:10 EDT
*** Bug 65774 has been marked as a duplicate of this bug. ***
Comment 4 Carolyn MacLeod CLA 2004-06-15 11:45:37 EDT
*** Bug 66896 has been marked as a duplicate of this bug. ***
Comment 5 Carolyn MacLeod CLA 2004-06-15 12:08:44 EDT
Agree with comment #2, and I think that when the user clicks on the 'combined 
annotation icon' in the overview ruler, the code should unfold and the editor 
should be scrolled to the location of the first annotation in the previously 
folded region (just as if the code was not folded).
Comment 6 Dani Megert CLA 2004-09-03 03:47:10 EDT
*** Bug 73133 has been marked as a duplicate of this bug. ***
Comment 7 Dani Megert CLA 2004-10-21 08:59:08 EDT
*** Bug 76650 has been marked as a duplicate of this bug. ***
Comment 8 Dani Megert CLA 2005-01-07 02:41:03 EST
*** Bug 82348 has been marked as a duplicate of this bug. ***
Comment 9 Rob Spahitz CLA 2005-01-07 12:29:10 EST
See bug# 82348 for proposed change (i.e. option to enable or disable 
this "feature")
Comment 10 Dani Megert CLA 2005-06-04 09:55:59 EDT
*** Bug 98367 has been marked as a duplicate of this bug. ***
Comment 11 Dani Megert CLA 2005-06-13 11:24:24 EDT
*** Bug 71758 has been marked as a duplicate of this bug. ***
Comment 12 Dani Megert CLA 2005-07-11 05:30:30 EDT
*** Bug 103114 has been marked as a duplicate of this bug. ***
Comment 13 Dani Megert CLA 2005-11-07 13:08:18 EST
*** Bug 113392 has been marked as a duplicate of this bug. ***
Comment 14 Dani Megert CLA 2005-11-07 13:08:36 EST
Time permitting for 3.2
Comment 15 Dani Megert CLA 2006-03-27 14:58:17 EST
This has to be deferred.
Comment 16 Mik Kersten CLA 2006-05-16 16:45:49 EDT
*** Bug 109314 has been marked as a duplicate of this bug. ***
Comment 17 Mik Kersten CLA 2007-02-26 15:38:13 EST
For a bug this old it would be helpful to get a sense of whether it will be considered for the future or whether it is considered low priority now that it is no longer on the 3.3 plan.  For example, on the Mylar end we may need to plan some additional UI to work around this, because in the presence of having Mylar folding most declarations in a typical Java file, the overview ruler can no longer be 'trusted' by the user as a mechanism for finding matches or other important annotations.
Comment 18 Dani Megert CLA 2007-02-27 02:27:27 EST
This depends on how much resources we will have for the next release and what the themese will be. Of course a patch is always welcome if someone is really hot for a feature / bug fix.
Comment 19 Mik Kersten CLA 2007-09-06 17:44:13 EDT
Will this be considered for the 3.4 plan?
Comment 20 Dani Megert CLA 2007-09-07 07:10:57 EDT
Not without help.
Comment 21 Dani Megert CLA 2009-09-14 09:36:33 EDT
Created attachment 147100 [details]
Work in progress (using internal code)

The fix for this decrease performance in case of enabled folding.
Comment 22 Dani Megert CLA 2010-01-20 11:48:35 EST
Fixed in HEAD.
Available in builds > N20100119-2000.
Comment 23 Deepak Azad CLA 2010-01-26 04:31:26 EST
Verified with I20100125-0800 for 3.6 M5.
Comment 24 Dani Megert CLA 2010-01-26 04:37:21 EST
.