Bug 63023 - [RCP] IDEWorkbenchAdvisor is still using features
Summary: [RCP] IDEWorkbenchAdvisor is still using features
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Andrew Eidsness CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2004-05-19 13:05 EDT by Dorian Birsan CLA
Modified: 2004-06-09 09:36 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dorian Birsan CLA 2004-05-19 13:05:45 EDT 
I was under the impression that the about info and other places in UI should 
be independent of features, and use IProduct and IBundleGroup instead.
Currently, there are still calls to get the primary feature, etc. which should 
be replaced by Platform.getProduct(), etc.
Comment 1 Jeff McAffer CLA 2004-05-19 16:15:03 EDT 
yes, I saw this too while doing some performance work.  Everything needed 
should be availble from IProduct and IBundleGroup.  Using the feature support 
is duplicating work already done by update.
Comment 2 Nick Edgar CLA 2004-05-19 16:54:37 EDT 
We only converted UI, not IDE.  But it should be possible to get away from
features in IDE as well.  There was another bug reported about the performance
impact of this, but I'll keep this separate.
Comment 3 Jeff McAffer CLA 2004-05-20 10:50:05 EDT 
See bug 68982 also.

The key issue here is for the UI to define a Product extension.  If it did this 
then 
a) it would be a good example for others
b) it would avoid running a mess of legacy code in Update which ends up reading 
a mess o files etc etc. (i.e., performance gain)
Comment 4 Andrew Eidsness CLA 2004-05-21 14:47:12 EDT 
Jeff is particularly interested in having IDEWorkbenchPlugin.getPrimaryInfo 
fixed, as it seems to get called alot.  The method retrieves the current 
platform configuration which causes update to do alot of work.

Even if we don't get all of IDE off the old stuff, it should be possible to 
update the commonly used methods (such as this one).
Comment 5 Andrew Eidsness CLA 2004-06-08 14:43:36 EDT 
A fix for this has been reviewed by nick and submitted to HEAD.
Comment 6 Andrew Eidsness CLA 2004-06-09 09:36:04 EDT 
I've verified that this is working properly in build 200406090800.