Bug 62245 - [ProblemsView] improve presentation of current error/warning count
Summary: [ProblemsView] improve presentation of current error/warning count
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC3   Edit
Assignee: Debbie Wilson CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2004-05-14 07:13 EDT by Erich Gamma CLA
Modified: 2005-08-04 06:19 EDT (History)
1 user (show)

See Also:


Attachments
annotated problems view (13.87 KB, image/gif)
2004-05-14 07:16 EDT, Erich Gamma CLA
no flags Details
patch for improved error breakdown presentation (2.90 KB, patch)
2004-06-16 07:15 EDT, Erich Gamma CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Gamma CLA 2004-05-14 07:13:17 EDT
The number of problems and warning in the workspace is important for the user. 
Currently the problems view presents the following counts:
1) the number of items matching the filter in the title bar
2) the number of errors/warnings and infos in the status line
The issue is that since the errors and warnings are shown in the status line, 
they are only visible when the problems view is active. 

Also for the user the number of errors is as important as the number of items 
that match the current filter.

For this reason the proposal is to move the error and warning count to the 
title bar and to show it together with the filtered item count.

See the attached screenshot
Comment 1 Erich Gamma CLA 2004-05-14 07:16:44 EDT
Created attachment 10643 [details]
annotated problems view
Comment 2 Michael Van Meekeren CLA 2004-05-14 12:18:56 EDT
so you are suggesting we remove the message from the workbench window status 
line?
Comment 3 Erich Gamma CLA 2004-05-14 12:46:36 EDT
these are the different cases:
- no selection
  old->show the problem counts
  new->show nothing
- single selection
  no change
- multi-selection
  old-># items selected: problem counts
  new-># items selected
Comment 4 Nick Edgar CLA 2004-05-14 15:33:19 EDT
I think this makes sense.
Comment 5 Michael Van Meekeren CLA 2004-06-14 13:31:13 EDT
Erich, were you going to give us a patch for this?
Comment 6 Erich Gamma CLA 2004-06-15 17:21:44 EDT
yes - I have the patch, will be reviewed locally and made available Wed morning
Comment 7 Erich Gamma CLA 2004-06-16 07:15:48 EDT
Created attachment 12230 [details]
patch for improved error breakdown presentation
Comment 8 Erich Gamma CLA 2004-06-16 12:48:52 EDT
here is the test case:
1) in a fresh workspace, create a project, with a single *.java file
2) add two syntax errors to the *.java file
->the content description should show: "2 errors, 0 warnings, 0 infos"

3) activate the problems view
->the status line should be empty

4) select a single error
->the error description shows up in the status line

5) select both errors
->a break down of the selection is shown in the status line: "2 items 
selected: 2 errors...

6) set a filter, so that all errors are filtered
->content description shows: "0 errors, 0 warnings, 0 infos (Filter matched 0 
of 2 items)
Comment 9 Debbie Wilson CLA 2004-06-16 19:50:59 EDT
Patch applied.  Fix should be available I20040617*.
Erich, I took out the redefinition of updateSummaryVisible to just return an 
empty string.  This is what MarkerView will give us anyway.
Comment 10 Debbie Wilson CLA 2004-06-17 13:36:59 EDT
Verified I20040617 (0800).