Bug 62108 - [Contexts] Context updating takes 15% of text editor opening time
Summary: [Contexts] Context updating takes 15% of text editor opening time
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.0   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2004-05-13 11:19 EDT by Tod Creasey CLA
Modified: 2004-05-13 16:49 EDT (History)
1 user (show)

See Also:

Attachments
Trace for editor opening (72.43 KB, text/html)
2004-05-13 11:23 EDT, Tod Creasey CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2004-05-13 11:19:48 EDT 
Updating of the contexts takes 15% of the time to open a text editor. This 
appears to be doing the same thing twice

The two places are

1) Activation callback on the shell takes 5.82% of the time 
(WorkbenchContextSupport.processEnabledSubmissions())
2) Mouse activation causes a setActiveControl on the shell. This also calls 
WorkbenchContextSupport.processEnabledSubmissions()

If we removed one of these callbacks (or optimized the processing) this could 
save quite a bit of time.
Comment 1 Tod Creasey CLA 2004-05-13 11:23:19 EDT 
Created attachment 10606 [details]
Trace for editor opening
Comment 2 Tod Creasey CLA 2004-05-13 11:24:38 EDT 
The current time for this code is 608 ms in OptimizeIt.
Comment 3 Douglas Pollock CLA 2004-05-13 11:38:04 EDT 
Please cross-test on 2.1.3.
Comment 4 Tod Creasey CLA 2004-05-13 14:10:21 EDT 
KeyBindingService took 196ms and was also updating twice on 2.1.3 as it is 
now. It took 33% of the startup time then.
Comment 5 Douglas Pollock CLA 2004-05-13 16:49:13 EDT 
Tod says we've now dropped below our 2.1.3 times.