Bug 62101 - [Commands] Command updating takes 32% of text editor startup time
Summary: [Commands] Command updating takes 32% of text editor startup time
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.0   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2004-05-13 10:48 EDT by Tod Creasey CLA
Modified: 2004-05-13 16:48 EDT (History)
1 user (show)

See Also:

Attachments
Trace of the startup with focus on contexts (109.46 KB, text/html)
2004-05-13 11:14 EDT, Tod Creasey CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2004-05-13 10:48:42 EDT 
Looking at the trace for the time to open a text editor 32% of it was spent 
updating the command support.

The main two areas were 

AbstractTextEditor.createActions (35 invocations of addHandlerSubmission)
AbstractTextEditor.createNavigationActions (43 invocations of 
addHandlerSubmission)

I was opening the build.properties file of org.eclipse.ui.workbench in the 
Resource Perspective with no other perspectives open
Comment 1 Tod Creasey CLA 2004-05-13 11:14:33 EDT 
Created attachment 10605 [details]
Trace of the startup with focus on contexts
Comment 2 Tod Creasey CLA 2004-05-13 11:31:15 EDT 
For future reference the time I currently have for this is:

AbstractTextEditor.createActions 596ms
AbstractTextEditor.createNavigationActions 640 ms
Comment 3 Douglas Pollock CLA 2004-05-13 11:36:29 EDT 
Could you please profile against 2.1.3 as well?
Comment 4 Tod Creasey CLA 2004-05-13 14:06:06 EDT 
The entire editor takes 580ms on 2.1.3. 

WorkbenchPage.activate() takes 304 ms and EditorManager.openEditor() takes 
276ms
Comment 5 Tod Creasey CLA 2004-05-13 14:08:33 EDT 
More stats

KeyBindingService took 196ms and was also updating twice
Comment 6 Douglas Pollock CLA 2004-05-13 14:43:56 EDT 
I'm not sure what the relationship is between the 2.1.3 statistics and 3.0.0 
statistics.  Could you post times on the same methods?
Comment 7 Tod Creasey CLA 2004-05-13 14:54:26 EDT 
The two sets of times represent the time of the entry point into key bindings 
and commands in both releases.
Comment 8 Douglas Pollock CLA 2004-05-13 16:48:48 EDT 
Tod says that we have now dipped below our times for 2.1.3.  Closing this bug.