Community
Participate
Working Groups
20040511-1600 Creation of the PartStack presentation takes 3.1 seconds on a workbench with the following state: 1) Workbench has platform-ui module loaded 2) No editors open 3) Only the resource perspective is opened 4) Default views for the resource perspective Note it is likely not as bad as that as the profiler affects this time. I will attach the trace
Created attachment 10549 [details] Optimize it output
Hmm... a good portion of that runtime was probably spent creating the view's widgetry. The troubling part is that both ViewPane.createControl() and DefaultPartPresentation.selectPart() are running slow -- only one of them should be creating the view's widgetry.
Adding my name to the cc list as we are now tracking performance issues more closely. Please remove the performance keyword if this is not a performance bug.
Stefan, is this still happening? Is this PR still relevant?
This PR is rather vague, but it's still relevant. I'm working to speed up PartStack creation on several fronts: 1. Reducing the number of widgets required for the default presentation 2. Speeding up the presentation layout 3. Reducing the number of times we need to create PartStack widgets 4. Reducing the number of parts that get activated by PartStack There's different PRs for each of these issues. Number 4 has already happened, number 3 will speed up perspective switches greatly but not startup, and layout is already pretty fast (although we can still squeeze out some more cycles) so I think the only remaining startup gain would come from 1... although I wouldn't expect more than 20% improvement. Besides making the parts themselves open faster, these are the only optimizations I'm aware of. If anyone knows of other areas where PartStack could be improved, please draw them to my attention.
If there are already PRs covering those cases, I would mark this one as a dup of the one that most closely matches it, since it really isn't adding a lot of value.
Is this still a problem in 3.3? PW
Is what still a problem? As it says in the comments for this bug, several optimizations could likely still be done, and they may be covered by other bugs. If you're asking "Are we now fast enough at creating the PartStack presentation?", the obvious answer is "No, but maybe machines are fast enough now that I won't notice."
Changes requested on bug 193523
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
