Bug 61628 - [Workbench] Animating close rectangle is barely visible on the MAC
Summary: [Workbench] Animating close rectangle is barely visible on the MAC
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Stefan Xenos CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2004-05-10 13:48 EDT by Michael Van Meekeren CLA
Modified: 2004-06-11 13:06 EDT (History)
5 users (show)

See Also:


Attachments
Reimplements RectangleAnimation using a Shell (10.46 KB, patch)
2004-06-02 20:24 EDT, Stefan Xenos CLA
no flags Details | Diff
Fixes IllegalArgumentException in previous patch (10.51 KB, patch)
2004-06-02 20:37 EDT, Stefan Xenos CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Van Meekeren CLA 2004-05-10 13:48:01 EDT
By clicking on the "Run in Background" button on the Jobs dialog that shows running jobs, it will cause 
the dialog to animate down to the bottom right of the window.

On the mac, the color of the rectangle seems to be too light and you can not see it animate, You just 
get the odd light coloured line being drawn on the workbench.

This means the user misses the intent of the animation completely
Comment 1 Stefan Xenos CLA 2004-05-11 16:02:58 EDT
The animation has been disabled for all non-windows platforms, so the rendering
problems should be gone. 

I have filed bug 61791 requesting new API to make the animation
platform-independent.
Comment 2 Michael Van Meekeren CLA 2004-05-28 17:01:09 EDT
This should not be marked as fixed unless bug 61791 is the only way to fix 
this. 
I think it is an important polish item.  Is there something we can do here?
Comment 3 Stefan Xenos CLA 2004-05-28 17:34:44 EDT
Yes... Steve suggested using transparent shells, which is still
platform-specific, but should work on most of the platforms Eclipse supports.
Comment 4 Jean-Michel Lemieux CLA 2004-06-02 11:45:42 EDT
This is an important feature to have on non-window platforms, since the effect
of the run in background is lost without the animation. If the tracker provides
the best platform-independant way of animating the rectangle, than bug 61791
should be marked as the polish item.
Comment 5 Stefan Xenos CLA 2004-06-02 20:24:35 EDT
Created attachment 11518 [details]
Reimplements RectangleAnimation using a Shell

This patch makes the following changes:
- Implements Steve's suggestion of using nonrectangular shells instead of a
NO_BACKGROUND Canvas
- Changes the animation duration to 400ms (from 250ms)
- Adds animations when turning a detached window into a fastview, and when
restoring a fastview from the fastview bar context menu.
- Re-enables animations on the Mac and GTK

I've only tested this on Windows so far.
Comment 6 Stefan Xenos CLA 2004-06-02 20:28:52 EDT
Note: the animation is not as smooth using nonrectangular shells. I needed to
increase the animation duration or it is hardly visible.

The shell approach has the significant advantage that you can still click on the
workbench while the animation is happening.

There is a bit of a focus problem here. When I create the animation Shell, it
grabs keyboard focus. I've worked around this by remembering the focus control
before I open the Shell, and manually setting focus back to where it was... but
there is probably a nicer way to do this.
Comment 7 Stefan Xenos CLA 2004-06-02 20:37:21 EDT
Created attachment 11519 [details]
Fixes IllegalArgumentException in previous patch

Fixes a bug in the previous patch: in certain situations, a rectangle with
negative area would be passed to Region.subtract
Comment 8 Stefan Xenos CLA 2004-06-03 11:33:46 EDT
Fixed in head. Tested on mac. Modified patch with changes from Steve
Comment 9 Ines Khelifi CLA 2004-06-11 12:18:30 EDT
Verified on Mac OS 10.3.3 using I200406110010. Kim, can you mark as verified?
Thanks.
Comment 10 Kim Horne CLA 2004-06-11 13:06:25 EDT
Verified.