Bug 61478 - [JavaDoc] [ActionSets] JavaDoc API clarification on IWorkbenchPage#showActionSet(String)
Summary: [JavaDoc] [ActionSets] JavaDoc API clarification on IWorkbenchPage#showAction...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-07 19:36 EDT by Jared Burns CLA
Modified: 2019-09-06 16:09 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2004-05-07 19:36:43 EDT
IWorkbenchPage#showActionSet(String) doesn't turn on the given action set if it's been 
previously disabled by the user. I didn't know this and had to debug through the implementation 
(not very far, fortunately :)) to figure out what was going on. I think the behavior is fine, but the 
JavaDoc should mention it.
Comment 1 Nick Edgar CLA 2004-05-10 11:01:22 EDT
I actually find this behaviour strange.  Can you explain why you think it's OK?
Comment 2 Jared Burns CLA 2004-05-10 11:48:49 EDT
I think it's OK in the sense that I can call this API as a client without having to worry about overriding 
the user's choice. For example, we (I) just released code that turns on the Debug action set when the 
Debug view is activated. This is a major help to users because it means they'll finally get their stepping 
hotkeys whenever they open the view. But without this behavior, we'd keep turning on the action set 
even if they really wanted it off.

Ideally, I think there should be a boolean flag on the method, "force", that lets clients explicitly state 
whether or not they want this behavior.
Comment 3 Nick Edgar CLA 2004-05-10 11:53:41 EDT
Probably better for you to use the actionSetPartAssociations extension point.
This allows you to associate an action set with a part (view or editor).
If the user hides the action set, that is remembered by the workbench, and it
will not be added back, e.g. if the user closes and reopens the view.


Comment 4 Jared Burns CLA 2004-05-10 12:25:32 EDT
I don't think that extension point is really usable for us, unfortunately. From the 
actionSetPartAssociations schema: 
  "In the case of a view, the action set will be visible when the view is the active part."

We need the Debug action set turned on whenever there's a Debug view in the perspective, regardless 
of whether or not it's the "active part". Very often when debugging, the user has focus in the editor or 
some other view while they're stepping.
Comment 5 Paul Webster CLA 2007-04-05 19:03:06 EDT
Assigning to component owner
PW
Comment 6 Eclipse Webmaster CLA 2019-09-06 16:09:16 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.