Bug 60964 - Job#isBlocking doesn't work for all cases
Summary: Job#isBlocking doesn't work for all cases
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.5 M5   Edit
Assignee: Jan Koehnlein CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 194794 454698 (view as bug list)
Depends on:
Blocks: 48840 56823
  Show dependency tree
 
Reported: 2004-05-04 16:11 EDT by Michael Valenta CLA
Modified: 2017-12-05 17:47 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2004-05-04 16:11:55 EDT 
Job#isBlocking() only works when the job's scheduling rule is blocking another 
job. It does not detect blockages causes by IJobManager#beginRule. I wonder if 
there should be API on IJobManager (i.e. isBlocking) that indicates whether 
the current thread is blocking another thread (i.e. not only jobs can block 
other threads).
Comment 1 John Arthorne CLA 2007-06-28 11:48:16 EDT 
*** Bug 194794 has been marked as a duplicate of this bug. ***
Comment 2 Szymon Ptaszkiewicz CLA 2014-12-12 08:10:22 EST 
*** Bug 454698 has been marked as a duplicate of this bug. ***
Comment 3 Szymon Ptaszkiewicz CLA 2014-12-12 08:26:15 EST 
Jan, could you resubmit your patch with reference to this bug?
Comment 4 Szymon Ptaszkiewicz CLA 2014-12-12 08:33:45 EST 
(In reply to Szymon Ptaszkiewicz from comment #3)
> Jan, could you resubmit your patch with reference to this bug?

Actually, it will be faster if I do that myself.
Comment 5 Szymon Ptaszkiewicz CLA 2014-12-12 09:06:56 EST 
https://git.eclipse.org/r/#/c/37938/
Comment 6 Lars Vogel CLA 2014-12-12 10:52:33 EST 
Adding 4.4M5 target, as the DUP was tagged with that.
Comment 7 Szymon Ptaszkiewicz CLA 2014-12-15 05:26:04 EST 
Fixed in master with:

http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=c360f95ecdfffb77825f1004776dfccb5f3d4b81

Thanks, Jan!
Comment 8 Szymon Ptaszkiewicz CLA 2014-12-15 05:26:49 EST 
Marking resolved.
Comment 9 Szymon Ptaszkiewicz CLA 2014-12-17 04:52:15 EST 
Verified in I20141216-0800.
Comment 10 Szymon Ptaszkiewicz CLA 2014-12-18 07:13:27 EST 
I pushed also additional comment to document the change:

http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=58356ffe673246fd999c62d9665d4f374a5e25e0