Bug 59206 - Perf: JavaCommandStackPropertySheetEntry gets name and value often
Summary: Perf: JavaCommandStackPropertySheetEntry gets name and value often
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: VE (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: VE Bugzilla inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-20 04:57 EDT by Joe Winchester CLA
Modified: 2011-06-13 11:36 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Winchester CLA 2004-04-20 04:57:37 EDT 
Noticed this doing debugging.  The JavaCommandStackPropertySheetEntry (mainly 
via inherited code) called getText(Object) 3 times for every property when a 
JavaBean is selected, and also calls getName() several times.  getText(Object) 
often requires a VM round trip, and getName() requires searching decorator 
lists.  For performance it seems that the entry could cache these.
I also am having second thoughts about the property descriptor caching the 
label provider instance.  Instead we should change it to cache the method 
proxy used to create it - it will mean that people can hold onto values if 
they want to, and the real problem isn't that construction was slow, it was 
that it occured too often.
Comment 1 Gili Mendel CLA 2004-04-20 08:45:16 EDT 
Performance